Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android support #60

Open
claudeha opened this issue Mar 2, 2020 · 1 comment
Open

Android support #60

claudeha opened this issue Mar 2, 2020 · 1 comment

Comments

@claudeha
Copy link

claudeha commented Mar 2, 2020

The old Makefile template from SVN had support for Android (which may have bitrotted; I haven't tried it myself..). Could be nice if this build system supported it also.

Example in the wild: https://github.com/agraef/pd-lua/blob/master/Makefile#L158-L191

@katjav
Copy link
Contributor

katjav commented Mar 8, 2020

Would be nice indeed. I'm totally unfamiliar with this but here's some remarks for anyone who wants to add Android support.

Makefile.pdlibbuilder's internal variables are all written in lower case (in contrast with the old Makefile template). Upper case variables are intended for the user as make command argument or environment variable. In the case of cross compilation the user will define PLATFORM to hold the target triplet. Makefile.pdlibbuilder stores the isolated components thereof as a list in variable target.triplet. From there, target system Android could be detected like so:

ifneq ($(filter android%, $(target.triplet)),)
  system = Android
endif

and the Android section would start like:

ifeq ($(system), Android)

The Android section must be evaluated after the general Linux section so it can inherit some variable definitions and overwrite others.

umlaeute added a commit that referenced this issue Mar 9, 2020
compiles on dockcross/android-arm and dockcross/android-arm64
not runtime tests have been performed yet (as i only have a cross-compilation environment)

Related: #60
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants