Added generator for Table class for StorIOSQLiteProcessor. (Issue #694) #734

pbochenski · 2016-12-12T08:09:49Z

Since all data for creating such class is already in annotation processors META classes it might save some boilerplate to create such class automatically.
It generates SQL code for creating table, for additive update (only adds columns) and stores table name and column names in easy to use way.

Since all data for creating such class is already in annotation processors META classes it might save some boilerplate to create such class automatically. It generates SQL code for creating table, for additive update (only adds columns) and stores table name and column names in easy to use way.

codecov-io · 2016-12-12T08:20:22Z

Codecov Report

Merging #734 into master will not change coverage.

@@           Coverage Diff           @@
##           master     #734   +/-   ##
=======================================
  Coverage   96.05%   96.05%           
=======================================
  Files          87       87           
  Lines        2459     2459           
  Branches      329      329           
=======================================
  Hits         2362     2362           
  Misses         68       68           
  Partials       29       29

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5d3fdb...740a589. Read the comment docs.

nikitin-da

Great work!
In few cases (updating, deleting fields, adding constrains) we have to (and we can) handle it manually and in all other it will be really helpful!

nikitin-da · 2016-12-14T06:16:29Z

...nnotations/src/main/java/com/pushtorefresh/storio/sqlite/annotations/StorIOSQLiteColumn.java

+     *
+     * @return version of database on which column was added.
+     */
+    int version() default 0;


Should we start from 1? Because it is the base value by docs

nikitin-da · 2016-12-14T06:17:40Z

storio-basic-sample-app/src/main/java/com/pushtorefresh/storio/basic_sample/Tweet.java

    String content;

+    // This column is not used in app, but shows how update code is generated
+    @StorIOSQLiteColumn(name = "NewColumn", ignoreNull = true, version = 1)


Maybe make name snake case like another fields?

nikitin-da · 2016-12-14T06:18:52Z

storio-basic-sample-app/src/main/java/com/pushtorefresh/storio/basic_sample/Tweet.java

    String content;

+    // This column is not used in app, but shows how update code is generated
+    @StorIOSQLiteColumn(name = "NewColumn", ignoreNull = true, version = 1)
+    String newColumn;


And add nullability please ;)

nikitin-da · 2016-12-14T06:21:06Z

storio-basic-sample-app/src/main/java/com/pushtorefresh/storio/basic_sample/TweetsQueries.java

+
+import com.pushtorefresh.storio.sqlite.queries.Query;
+
+// We suggest to store table meta such as table name, columns names, queries, etc in separate class


to store table meta such as table name,

nikitin-da · 2016-12-14T06:22:50Z

.../main/java/com/pushtorefresh/storio/common/annotations/processor/introspection/JavaType.java

-    DOUBLE_OBJECT,
-    STRING,
-    BYTE_ARRAY;
+    JavaType(String sqlType) {


nikitin-da · 2016-12-14T06:29:40Z

...main/java/com/pushtorefresh/storio/sqlite/annotations/processor/generate/TableGenerator.java

+import static com.pushtorefresh.storio.common.annotations.processor.generate.Common.INDENT;
+
+/**
+ * Created by Pawel Bochenski on 11.12.2016.


We try to remove file headers

nikitin-da · 2016-12-14T06:32:29Z

...main/java/com/pushtorefresh/storio/sqlite/annotations/processor/generate/TableGenerator.java

+                .build();
+    }
+
+    private Iterable<FieldSpec> generateFields(String table, Collection<StorIOSQLiteColumnMeta> columns) {


Add please nullability for methods in this file)

nikitin-da · 2016-12-14T06:33:21Z

...main/java/com/pushtorefresh/storio/sqlite/annotations/processor/generate/TableGenerator.java

+                .initializer("$S", table)
+                .addModifiers(Modifier.PUBLIC, Modifier.STATIC, Modifier.FINAL)
+                .build());
+        for (StorIOSQLiteColumnMeta m : columns) {


m -> meta or column?!

nikitin-da · 2016-12-14T06:39:55Z

...main/java/com/pushtorefresh/storio/sqlite/annotations/processor/generate/TableGenerator.java

+        int i = 0;
+        for (StorIOSQLiteColumnMeta entry : columns) {
+            code += entry.storIOColumn.name() + " " + entry.javaType.getSqlType();
+            if (!entry.storIOColumn.ignoreNull()) {


=( ignoreNull absence doesn't guarantee database value existence.
It's just prevent overriding db field of there is no value in java entity.
Can we check NotNull, NonNull annotations?

nikitin-da · 2016-12-14T06:40:06Z

...main/java/com/pushtorefresh/storio/sqlite/annotations/processor/generate/TableGenerator.java

+            if (!entry.storIOColumn.ignoreNull()) {
+                code += " NOT NULL";
+            }
+            if (entry.storIOColumn.key()) {


nikitin-da · 2016-12-14T06:50:07Z

Closes #694

Creating NOT NULL column now depends on field annotation (NonNull or NotNull)

nikitin-da · 2016-12-16T06:02:31Z

Thanks, @pbochenski !
@artem-zinnatullin PTAL, please)

artem-zinnatullin

Tests!!

artem-zinnatullin · 2016-12-20T20:44:20Z

...main/java/com/pushtorefresh/storio/sqlite/annotations/processor/generate/TableGenerator.java

+
+import static com.pushtorefresh.storio.common.annotations.processor.generate.Common.INDENT;
+
+public class TableGenerator implements Generator<StorIOSQLiteTypeMeta> {


This needs lots of tests :)

artem-zinnatullin · 2016-12-20T20:46:40Z

storio-basic-sample-app/src/main/java/com/pushtorefresh/storio/basic_sample/Tweet.java

 // Just a class for demonstration, real Tweet structure is more complex.

 // This annotation will trigger annotation processor
 // Which will generate type mapping code in compile time,
 // You just need to link it in your code.
-@StorIOSQLiteType(table = TweetsTable.TABLE)
+@StorIOSQLiteType(table = "tweets")


Nice! But I not sure that everyone will need generated class, maybe add flag to this annotation? Something like @StorIOSQLiteType(table = "tweets", generateTableClass = false) which will be true by default?

artem-zinnatullin · 2017-07-06T13:18:33Z

@geralt-encore can you please rebase this and merge? You're expert in StorIO annotation processing :)

geralt-encore · 2017-07-06T17:05:27Z

That will be tough since annotation processor was rewritten quite a lot since this PR...

geralt-encore · 2017-10-17T07:09:28Z

I'll try to convert it in the near future

nikitin-da · 2017-10-28T21:36:42Z

Closed via #840

removed testing code from basic sample app

bea0ff6

nikitin-da requested changes Dec 14, 2016

View reviewed changes

fixed some nullability annotations and names.

81acd08

Creating NOT NULL column now depends on field annotation (NonNull or NotNull)

nikitin-da approved these changes Dec 16, 2016

View reviewed changes

nikitin-da requested a review from artem-zinnatullin December 19, 2016 15:49

artem-zinnatullin requested changes Dec 20, 2016

View reviewed changes

pawel bochenski added 2 commits December 27, 2016 21:54

added unit test for table generation

46ea6d4

added option to turn off feature of creating table

740a589

geralt-encore mentioned this pull request Oct 24, 2017

Table generator #840

Merged

nikitin-da closed this Oct 28, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added generator for Table class for StorIOSQLiteProcessor. (Issue #694) #734

Added generator for Table class for StorIOSQLiteProcessor. (Issue #694) #734

pbochenski commented Dec 12, 2016

codecov-io commented Dec 12, 2016 •

edited

Loading

nikitin-da left a comment

nikitin-da Dec 14, 2016

nikitin-da Dec 14, 2016

nikitin-da Dec 14, 2016

nikitin-da Dec 14, 2016 •

edited

Loading

nikitin-da Dec 14, 2016

nikitin-da Dec 14, 2016

nikitin-da Dec 14, 2016

nikitin-da Dec 14, 2016

nikitin-da Dec 14, 2016

nikitin-da Dec 14, 2016

nikitin-da commented Dec 14, 2016

nikitin-da commented Dec 16, 2016

artem-zinnatullin left a comment

artem-zinnatullin Dec 20, 2016

artem-zinnatullin Dec 20, 2016

artem-zinnatullin commented Jul 6, 2017

geralt-encore commented Jul 6, 2017

geralt-encore commented Oct 17, 2017

nikitin-da commented Oct 28, 2017


		import com.pushtorefresh.storio.sqlite.queries.Query;

		// We suggest to store table meta such as table name, columns names, queries, etc in separate class


		import static com.pushtorefresh.storio.common.annotations.processor.generate.Common.INDENT;

		public class TableGenerator implements Generator<StorIOSQLiteTypeMeta> {

Added generator for Table class for StorIOSQLiteProcessor. (Issue #694) #734

Added generator for Table class for StorIOSQLiteProcessor. (Issue #694) #734

Conversation

pbochenski commented Dec 12, 2016

codecov-io commented Dec 12, 2016 • edited Loading

Codecov Report

nikitin-da left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nikitin-da Dec 14, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nikitin-da commented Dec 14, 2016

nikitin-da commented Dec 16, 2016

artem-zinnatullin left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

artem-zinnatullin commented Jul 6, 2017

geralt-encore commented Jul 6, 2017

geralt-encore commented Oct 17, 2017

nikitin-da commented Oct 28, 2017

codecov-io commented Dec 12, 2016 •

edited

Loading

nikitin-da Dec 14, 2016 •

edited

Loading