Table generator #840
Merged
Table generator #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #840 +/- ##
=========================================
Coverage 97.41% 97.41%
Complexity 791 791
=========================================
Files 91 91
Lines 2707 2707
Branches 305 305
=========================================
Hits 2637 2637
Misses 38 38
Partials 32 32Continue to review full report at Codecov.
|
nikitin-da
approved these changes
Oct 24, 2017
This was referenced Oct 28, 2017
|
Looks great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #734
Thanks @pbochenski for all the heavy-lifting and sorry that I had to re-implement it instead of fixing the initial PR. I hope you are fine with it.
So any further feedback for this will be much appreciated! The only downside I see now is that it will break projects where table classes with the similar naming pattern already exist. This can be fixed by not generating table class by default, which sounds ok to me.
And we need to add some documentation about this feature as well.