-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add AES support for encrypting PDF files #1918
Conversation
64517c9
to
b7b6dc8
Compare
* PdfWriter.encrypt: Add 'algorithm' parameter * PdfWriter: Add _encryption property * PdfWriter: Add _encrypt_entry property This change was made in another PR to avoid merge conflicts / get it merged soon. Full credit for the work goes to exiledkingcc who did all of the work in #1816 Co-authored-by: exiledkingcc <exiledkingcc@gmail.com>
b7b6dc8
to
fb5d21d
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1918 +/- ##
==========================================
+ Coverage 92.83% 93.39% +0.56%
==========================================
Files 34 34
Lines 7058 7040 -18
Branches 1389 1389
==========================================
+ Hits 6552 6575 +23
+ Misses 359 312 -47
- Partials 147 153 +6
☔ View full report in Codecov by Sentry. |
New Features (ENH): - Add AES support for encrypting PDF files (#1918, #1935, #1936, #1938) - Add page deletion feature to PdfWriter (#1843) Bug Fixes (BUG): - PdfReader.get_fields() attempts to delete non-existing index "/Off" (#1933) - Remove unused objects when cloning_from (#1926) - Add the TK.SIZE into the trailer (#1911) - add_named_destination() maintains named destination list sort order (#1930)
I can't understand. Wasn't AES encryption already supported? |
Decryption was supported, but not encryption. |
Will |
Not until But with |
So will Pycryptodome be a mandatory dependency? |
No, Pycryptodome is not mandatory and will stay optional. However, if you want to use modern encryption, you will need it. |
This change was made in another PR to avoid merge conflicts / get it merged soon. Full credit for the work goes to exiledkingcc in #1816