BUG: PdfReader.get_fields() attempts to delete non-existing index "/Off" #1933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinThoma
reviewed
Jun 30, 2023
MartinThoma
added
the
is-bug
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1933 +/- ##
=======================================
Coverage 92.85% 92.85%
=======================================
Files 34 34
Lines 7094 7094
Branches 1397 1397
=======================================
Hits 6587 6587
Misses 359 359
Partials 148 148
☔ View full report in Codecov by Sentry. |
MartinThoma
changed the title
PdfReader.get_fields() when "/Off" does not exist.
|
Very nice work 👏 It will be released to PyPI with If you want, I can add you as a contributor: https://pypdf.readthedocs.io/en/latest/meta/CONTRIBUTORS.html :-) |
MartinThoma
added a commit
that referenced
this pull request
Jul 2, 2023
New Features (ENH): - Add AES support for encrypting PDF files (#1918, #1935, #1936, #1938) - Add page deletion feature to PdfWriter (#1843) Bug Fixes (BUG): - PdfReader.get_fields() attempts to delete non-existing index "/Off" (#1933) - Remove unused objects when cloning_from (#1926) - Add the TK.SIZE into the trailer (#1911) - add_named_destination() maintains named destination list sort order (#1930)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered this bug while playing around with the library. Seemed like a fairly straightforward fix, but if there are issues with doing this, let me know.