Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Process CMYK in deflate images #1977

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Conversation

pubpub-zz
Copy link
Collaborator

closes #1954

@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Patch coverage: 71.42% and project coverage change: -0.03 ⚠️

Comparison is base (1d16ca5) 93.90% compared to head (dae25e2) 93.87%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1977      +/-   ##
==========================================
- Coverage   93.90%   93.87%   -0.03%     
==========================================
  Files          33       33              
  Lines        7006     7009       +3     
  Branches     1392     1394       +2     
==========================================
+ Hits         6579     6580       +1     
- Misses        275      276       +1     
- Partials      152      153       +1     
Impacted Files Coverage Δ
pypdf/filters.py 92.82% <71.42%> (-0.40%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pubpub-zz
Copy link
Collaborator Author

I have no data to complete the date and I prefer to keep the code.
@MartinThoma All yours

@MartinThoma MartinThoma changed the title BUG : process CMYK in deflate images BUG: Process CMYK in deflate images Jul 18, 2023
@MartinThoma MartinThoma merged commit c2a741e into py-pdf:main Jul 18, 2023
MartinThoma added a commit that referenced this pull request Jul 23, 2023
New Features (ENH):
-  Add is_open in outlines in PdfReader and PdfWriter (#1960)

Bug Fixes (BUG):
-  Search /DA in hierarchy fields (#2002)
-  Cope with different ISO date length (#1999)
-  Decode Black only/CMYK deviceN images (#1984)
-  Process CMYK in deflate images (#1977)

Developer Experience (DEV):
-  Add mypy to pre-commit (#2001)
-  Release automation (#1991, #1985)

[Full Changelog](3.12.2...3.13.0)
@pubpub-zz pubpub-zz deleted the CMYKdeflate branch September 2, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OSError: cannot write mode CMYK as PNG when enumerating images
2 participants