Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Decode Black only/CMYK deviceN images #1984

Merged
merged 5 commits into from
Jul 20, 2023
Merged

Conversation

pubpub-zz
Copy link
Collaborator

closes #1979

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Patch coverage: 43.75% and project coverage change: -0.09 ⚠️

Comparison is base (c2a741e) 93.87% compared to head (e2ed385) 93.79%.

❗ Current head e2ed385 differs from pull request most recent head 1384886. Consider uploading reports for the commit 1384886 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1984      +/-   ##
==========================================
- Coverage   93.87%   93.79%   -0.09%     
==========================================
  Files          33       33              
  Lines        7009     7023      +14     
  Branches     1394     1400       +6     
==========================================
+ Hits         6580     6587       +7     
- Misses        276      278       +2     
- Partials      153      158       +5     
Impacted Files Coverage Δ
pypdf/filters.py 91.54% <40.00%> (-1.29%) ⬇️
pypdf/constants.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MartinThoma MartinThoma changed the title BUG : decode Black only/CMYK deviceN images BUG: Decode Black only/CMYK deviceN images Jul 20, 2023
@MartinThoma MartinThoma self-requested a review July 20, 2023 16:16
@MartinThoma MartinThoma added the soon PRs that are almost ready to be merged, issues that get solved pretty soon label Jul 20, 2023
@pubpub-zz
Copy link
Collaborator Author

@MartinThoma, the codecov report is not good, however the results should be better. up to you to relaunch it

all yours 🙂

@MartinThoma MartinThoma merged commit 85ca63e into py-pdf:main Jul 20, 2023
@MartinThoma
Copy link
Member

I think it's an improvement, so I merged it :-)

MartinThoma added a commit that referenced this pull request Jul 23, 2023
New Features (ENH):
-  Add is_open in outlines in PdfReader and PdfWriter (#1960)

Bug Fixes (BUG):
-  Search /DA in hierarchy fields (#2002)
-  Cope with different ISO date length (#1999)
-  Decode Black only/CMYK deviceN images (#1984)
-  Process CMYK in deflate images (#1977)

Developer Experience (DEV):
-  Add mypy to pre-commit (#2001)
-  Release automation (#1991, #1985)

[Full Changelog](3.12.2...3.13.0)
@pubpub-zz pubpub-zz deleted the iss1979 branch September 2, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
soon PRs that are almost ready to be merged, issues that get solved pretty soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError: 'ArrayObject' object has no attribute 'get'
2 participants