Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiply by surface area to volume ratio #1489

Closed
valentinsulzer opened this issue May 21, 2021 · 0 comments · Fixed by #1790
Closed

Multiply by surface area to volume ratio #1489

valentinsulzer opened this issue May 21, 2021 · 0 comments · Fixed by #1790
Assignees
@valentinsulzer

Comments

@valentinsulzer
Copy link
Member

In all the degradation models that depend on a current (d.../dt = j), the RHS should be multiplied by surface area to volume ratio (a) to account for possible changes in active material
@valentinsulzer valentinsulzer self-assigned this Nov 9, 2021
valentinsulzer added a commit that referenced this issue Nov 9, 2021
@valentinsulzer
#1489 add surface area to volume ratio factor
e88fd31
@valentinsulzer valentinsulzer mentioned this issue Nov 9, 2021
Merged
8 tasks
valentinsulzer added a commit that referenced this issue Nov 9, 2021
@valentinsulzer
#1489 revert example and fix tests
03d2dec
valentinsulzer added a commit that referenced this issue Nov 9, 2021
@valentinsulzer
#1489 add comment on dimensionless
5b160d4
valentinsulzer added a commit that referenced this issue Nov 9, 2021
@valentinsulzer
#1489 fix half-cell models
1de9c11
valentinsulzer added a commit that referenced this issue Nov 9, 2021
@valentinsulzer
Merge pull request #1790 from pybamm-team/issue-1489-surface-area
884d6e9 
#1489 add surface area to volume ratio factor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@valentinsulzer valentinsulzer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#1489 add surface area to volume ratio factor pybamm-team/PyBaMM
1 participant
@valentinsulzer