#1489 add surface area to volume ratio factor

[valentinsulzer]

Description

Add surface area to volume ratio factor

Fixes #1489

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

• New feature (non-breaking change which adds functionality)
• Optimization (back-end change that speeds up the code)
• Bug fix (non-breaking change which fixes an issue)

Key checklist:

• No style issues: $ flake8
• All tests pass: $ python run-tests.py --unit
• The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

• Code is commented, particularly in hard-to-understand areas
• Tests added that prove fix is effective or that feature works

[brosaplanella]

Looks good, just a question: this is a dimensionless surface area to volume so it is 1 when there is no degradation, right?

[brosaplanella]

I think we should restore this script to its previous version.

[valentinsulzer]

oops yes

[valentinsulzer]

Yes it's dimensionless

[codecov]

Codecov Report

Merging #1790 (1de9c11) into develop (dd77bec) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop    #1790   +/-   ##
========================================
  Coverage    99.28%   99.28%           
========================================
  Files          343      343           
  Lines        18921    18945   +24     
========================================
+ Hits         18786    18810   +24     
  Misses         135      135           

Impacted Files	Coverage Δ
.../interface/lithium_plating/irreversible_plating.py	100.00% <100.00%> (ø)
...ls/interface/lithium_plating/reversible_plating.py	100.00% <100.00%> (ø)
...els/submodels/interface/sei/ec_reaction_limited.py	100.00% <100.00%> (ø)
...models/interface/sei/electron_migration_limited.py	100.00% <100.00%> (ø)
...ls/interface/sei/interstitial_diffusion_limited.py	100.00% <100.00%> (ø)
...models/submodels/interface/sei/reaction_limited.py	100.00% <100.00%> (ø)
...bmodels/interface/sei/solvent_diffusion_limited.py	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd77bec...1de9c11. Read the comment docs.