Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Current collector thickness duplicated #666

Closed
brosaplanella opened this issue Oct 16, 2019 · 1 comment · Fixed by #676
Closed

Current collector thickness duplicated #666

brosaplanella opened this issue Oct 16, 2019 · 1 comment · Fixed by #676

Comments

@brosaplanella
Copy link
Sponsor Member

In the cell parameters the current collector thicknesses appear twice. Is there a reason for that? If it is a typo, do we need only to remove the extra lines from the parameter file or does it need some tweaking in the code?
@valentinsulzer
Copy link
Member

Just a typo and should be fine removing the extra lines

brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Oct 21, 2019
@brosaplanella
pybamm-team#666 removed duplicated current collector thicknesses
9e85261
valentinsulzer added a commit that referenced this issue Oct 24, 2019
@valentinsulzer
#666 remove duplicate param
ee83a43
@valentinsulzer valentinsulzer mentioned this issue Oct 24, 2019
Merged
8 tasks
valentinsulzer added a commit that referenced this issue Oct 24, 2019
@valentinsulzer
Merge pull request #676 from pybamm-team/issue-666-current-collector-…
b21b738 
…duplicated

#666 remove duplicate param
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#666 remove duplicate param pybamm-team/PyBaMM
2 participants
@valentinsulzer @brosaplanella