Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#666 remove duplicate param #676

Merged
merged 1 commit into from
Oct 24, 2019

Conversation

valentinsulzer
Copy link
Member

@valentinsulzer valentinsulzer commented Oct 24, 2019

Description

Remove duplicate parameter
Fixes #666

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Oct 24, 2019

Codecov Report

Merging #676 into master will increase coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #676     +/-   ##
=========================================
+ Coverage   98.54%   98.64%   +0.1%     
=========================================
  Files         169      169             
  Lines        8441     9064    +623     
=========================================
+ Hits         8318     8941    +623     
  Misses        123      123
Impacted Files Coverage Δ
pybamm/expression_tree/vector.py 100% <0%> (ø) ⬆️
pybamm/expression_tree/functions.py 100% <0%> (ø) ⬆️
pybamm/discretisations/discretisation.py 100% <0%> (ø) ⬆️
pybamm/expression_tree/matrix.py 100% <0%> (ø) ⬆️
pybamm/expression_tree/array.py 100% <0%> (ø) ⬆️
pybamm/expression_tree/concatenations.py 98.11% <0%> (+0.06%) ⬆️
pybamm/spatial_methods/spatial_method.py 95.77% <0%> (+0.12%) ⬆️
pybamm/expression_tree/binary_operators.py 98.96% <0%> (+0.52%) ⬆️
pybamm/expression_tree/symbol.py 98.25% <0%> (+0.67%) ⬆️
pybamm/processed_variable.py 97.02% <0%> (+1.5%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79c9d34...ee83a43. Read the comment docs.

@valentinsulzer valentinsulzer merged commit b21b738 into master Oct 24, 2019
@valentinsulzer valentinsulzer deleted the issue-666-current-collector-duplicated branch October 24, 2019 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Current collector thickness duplicated
1 participant