Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v24.9.1 #502

Merged
merged 53 commits into from
Sep 18, 2024
Merged

Release v24.9.1 #502

merged 53 commits into from
Sep 18, 2024

Conversation

BradyPlanden
Copy link
Member

@BradyPlanden BradyPlanden commented Sep 16, 2024

Description

Release v24.9.1.

Remove optional [cite] dependency from PyBaMM as per this issue. This will be added back in a future patch release once PyBaMM releases their v24.9.1 patch.

Issue reference

Fixes # (issue-number)

Review

Before you mark your PR as ready for review, please ensure that you've considered the following:

  • Updated the CHANGELOG.md in reverse chronological order (newest at the top) with a concise description of the changes, including the PR number.
  • Noted any breaking changes, including details on how it might impact existing functionality.

Type of change

  • New Feature: A non-breaking change that adds new functionality.
  • Optimization: A code change that improves performance.
  • Examples: A change to existing or additional examples.
  • Bug Fix: A non-breaking change that addresses an issue.
  • Documentation: Updates to documentation or new documentation for new features.
  • Refactoring: Non-functional changes that improve the codebase.
  • Style: Non-functional changes related to code style (formatting, naming, etc).
  • Testing: Additional tests to improve coverage or confirm functionality.
  • Other: (Insert description of change)

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All unit tests pass: $ nox -s tests
  • The documentation builds: $ nox -s doctest

You can run integration tests, unit tests, and doctests together at once, using $ nox -s quick.

Further checks:

  • Code is well-commented, especially in complex or unclear areas.
  • Added tests that prove my fix is effective or that my feature works.
  • Checked that coverage remains or improves, and added tests if necessary to maintain or increase coverage.

Thank you for contributing to our project! Your efforts help us to deliver great software.

Dibyendu-IITKGP and others added 30 commits August 14, 2024 13:01
…files added for single pulse and multi-pulse HPPC data fitting, a thermal submodel is also added. Folder created to keep data files for running example cases.
…7-add-thermal-thevenin-example-remove-params-from-others
…ers' of https://github.com/pybop-team/PyBOP into 437-add-thermal-thevenin-example-remove-params-from-others
…for performance, small fixes/formating to notebooks
…st transformation arg in scipy_optimisers.py, updates transformation integration tests
… call to parameters.join(). Updts. fail_gradient within setter.
…le-remove-params-from-others

# Conflicts:
#	examples/notebooks/equivalent_circuit_identification.ipynb
…uild()` initial_state dict keys to docstring
…or-gaussianloglikelihood

Transformation fixes
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.04%. Comparing base (99632b9) to head (b8b8f45).
Report is 54 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #502   +/-   ##
=======================================
  Coverage   99.04%   99.04%           
=======================================
  Files          52       52           
  Lines        3546     3560   +14     
=======================================
+ Hits         3512     3526   +14     
  Misses         34       34           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BradyPlanden BradyPlanden linked an issue Sep 16, 2024 that may be closed by this pull request
@BradyPlanden BradyPlanden marked this pull request as ready for review September 16, 2024 12:25
@BradyPlanden
Copy link
Member Author

I've confirmed the testing suite passes when this release branch is installed locally via pip. It's now ready for review.

pre-commit-ci bot and others added 17 commits September 16, 2024 18:01
updates:
- [github.com/astral-sh/ruff-pre-commit: v0.6.4 → v0.6.5](astral-sh/ruff-pre-commit@v0.6.4...v0.6.5)
…ple-remove-params-from-others

Notebook example files added for ECM and folder structure updated.
…-IITKGP

docs: add Dibyendu-IITKGP as a contributor for example
…nsformations

Fixes for LogPosterior w/ GaussianLogLikelihood
@BradyPlanden BradyPlanden merged commit f0377a1 into main Sep 18, 2024
52 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Release v24.9.0 broken
4 participants