fix: avoid infinite loop in docs-live #1265
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1256
I didn't really get what the stb serve was used for so I rewrote the nox "docs-live" session the same way as in https://github.com/pradyunsg/sphinx-theme-builder/blob/16979342306d885f4a99c195628001be61e98e5a/noxfile.py#L23.
I don't experience the infinite loop anymore. My only question is what changes should we listen to ? the one from the documentation or the one from the src (or both) ?
This current implementation listen to the docs but as I'm never using it I don't know if it's the way people use it.