Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add doctests to release notes #4440

Merged
merged 1 commit into from
Sep 20, 2020
Merged

Add doctests to release notes #4440

merged 1 commit into from
Sep 20, 2020

Conversation

max-sixty
Copy link
Collaborator

@max-sixty max-sixty commented Sep 20, 2020 •
edited
Loading

Any other changes?

@dcherian
Copy link
Contributor

LGTM. thanks Max

@max-sixty max-sixty merged commit 633187e into pydata:master Sep 20, 2020
@max-sixty max-sixty deleted the release-16.1 branch September 20, 2020 19:33
@keewis
Copy link
Collaborator

keewis commented Sep 20, 2020 •
edited
Loading

Edit: thanks for releasing, @max-sixty!

first of all, current master fails to build on RTD, which is because of a title underline being too short, and a typo in the new dev version section:

xarray/doc/whats-new.rst

Lines 18 to 22 in 788cd60

.. _whats-new.{0.16.2}:
v{0.16.2} (unreleased)
---------------------

Other than that, I noticed we had a few PRs that merged into stable, which means that these commits were lost during the release. I guess these PRs were opened using RTD's Edit on Github links while viewing the stable docs, so a fix would be related to #2821.

@max-sixty
Copy link
Collaborator Author

Thanks for spotting those @keewis , let me fix

@max-sixty max-sixty mentioned this pull request Sep 20, 2020
Merged
@keewis
Copy link
Collaborator

keewis commented Sep 20, 2020 •
edited
Loading

I cherry-picked the commits to master, so only the fix for the Edit on Github and the title line are left

@max-sixty
Copy link
Collaborator Author

Ah great! I was just trying to figure out why I couldn't find them! Thanks!

@max-sixty
Copy link
Collaborator Author

In lieu of fixing #2821, we could add a step to the release doc to merge stable into master — would that fix the problem?

@keewis
Copy link
Collaborator

keewis commented Sep 20, 2020 •
edited
Loading

it should, but I'm not sure if we'd have other issues instead. I guess we could try both?

@max-sixty max-sixty mentioned this pull request Sep 20, 2020
Merged
@keewis keewis mentioned this pull request Sep 25, 2020
Merged
2 tasks
dcherian added a commit to dcherian/xarray that referenced this pull request Oct 9, 2020
@dcherian
Merge branch 'propagate-attrs' of github.com:dcherian/xarray into pro…
1f998f0 
…pagate-attrs

* 'propagate-attrs' of github.com:dcherian/xarray: (22 commits)
  silence sphinx warnings about broken rst (pydata#4448)
  Xarray open_mfdataset with engine Zarr (pydata#4187)
  Fix release notes formatting (pydata#4443)
  fix typo in io.rst (pydata#4250)
  Fix typo (pydata#4181)
  Fix release notes typo
  New whatsnew section
  Add notes re doctests (pydata#4440)
  Fixed dask.optimize on datasets (pydata#4438)
  Release notes for 0.16.1 (pydata#4435)
  Small updates to How-to-release + lint (pydata#4436)
  Fix doctests (pydata#4439)
  add a ci for doctests (pydata#4437)
  preserve original dimension, coordinate and variable order in ``concat`` (pydata#4419)
  Fix for h5py deepcopy issues (pydata#4426)
  Keep the original ordering of the coordinates (pydata#4409)
  Clearer Vectorized Indexing example (pydata#4433)
  Revert "Fix optimize for chunked DataArray (pydata#4432)" (pydata#4434)
  Fix optimize for chunked DataArray (pydata#4432)
  fix doc dataarray to netcdf (pydata#4424)
  ...
@andersy005 andersy005 mentioned this pull request May 2, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@max-sixty @dcherian @keewis