Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix release notes formatting #4443

Merged
merged 2 commits into from
Sep 20, 2020
Merged

Fix release notes formatting #4443

merged 2 commits into from
Sep 20, 2020

Conversation

max-sixty
Copy link
Collaborator

As per #4440

keewis
keewis approved these changes Sep 20, 2020
View reviewed changes
Copy link
Collaborator

@keewis keewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Feel free to merge on green

doc/whats-new.rst Outdated Show resolved Hide resolved
@max-sixty @keewis
Update doc/whats-new.rst
58aad31 
Co-authored-by: keewis <keewis@users.noreply.github.com>
@max-sixty
Copy link
Collaborator Author

I'm not sure why tests seem stuck. Going to merge given the minimal changes

@max-sixty max-sixty merged commit 1155f56 into pydata:master Sep 20, 2020
@max-sixty max-sixty deleted the release-notes-formatting branch September 20, 2020 23:31
@keewis
Copy link
Collaborator

keewis commented Sep 21, 2020 •
edited
Loading

each CI takes up to 30 minutes to complete, and since we only have 10 workers available they take quite a while to complete in case there are lots of CI runs. Most of the time is spent on the tests (we might be able to reduce the time spent there – in test_units, maybe?), but conda seems to also take up between 1 to 10 minutes.

@dcherian
Copy link
Contributor

We could use pytest-xdist but it breaks on test_sparse.py

dcherian added a commit to dcherian/xarray that referenced this pull request Oct 9, 2020
@dcherian
Merge branch 'propagate-attrs' of github.com:dcherian/xarray into pro…
1f998f0 
…pagate-attrs

* 'propagate-attrs' of github.com:dcherian/xarray: (22 commits)
  silence sphinx warnings about broken rst (pydata#4448)
  Xarray open_mfdataset with engine Zarr (pydata#4187)
  Fix release notes formatting (pydata#4443)
  fix typo in io.rst (pydata#4250)
  Fix typo (pydata#4181)
  Fix release notes typo
  New whatsnew section
  Add notes re doctests (pydata#4440)
  Fixed dask.optimize on datasets (pydata#4438)
  Release notes for 0.16.1 (pydata#4435)
  Small updates to How-to-release + lint (pydata#4436)
  Fix doctests (pydata#4439)
  add a ci for doctests (pydata#4437)
  preserve original dimension, coordinate and variable order in ``concat`` (pydata#4419)
  Fix for h5py deepcopy issues (pydata#4426)
  Keep the original ordering of the coordinates (pydata#4409)
  Clearer Vectorized Indexing example (pydata#4433)
  Revert "Fix optimize for chunked DataArray (pydata#4432)" (pydata#4434)
  Fix optimize for chunked DataArray (pydata#4432)
  fix doc dataarray to netcdf (pydata#4424)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keewis keewis keewis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@max-sixty @keewis @dcherian