Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raise on passing axis to Dataset.reduce methods #4940

Merged
merged 8 commits into from
Mar 4, 2021
Merged

raise on passing axis to Dataset.reduce methods #4940

merged 8 commits into from
Mar 4, 2021

Commits on Feb 21, 2021

  1. don't allow passing 'axis' to Dataset.reduce methods

    @keewis
    keewis committed Feb 21, 2021
    Configuration menu
    Copy the full SHA
    7be3001 View commit details
    Browse the repository at this point in the history

  2. check that Dataset.reduce raises for axis kwargs

    @keewis
    keewis committed Feb 21, 2021
    Configuration menu
    Copy the full SHA
    3ef47e9 View commit details
    Browse the repository at this point in the history

  3. update whats-new.rst [skip-ci]

    @keewis
    keewis committed Feb 21, 2021
    Configuration menu
    Copy the full SHA
    724a699 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2021

  1. remove the broken axis kwarg to Dataset argmin / argmax

    @keewis
    keewis committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    20c1d45 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2021

  1. remove tests which depended on axis being passed through by **kwargs

    @keewis
    keewis committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    ff776c3 View commit details
    Browse the repository at this point in the history

  2. don't try to test calling numpy reduce functions on dataset objects

    @keewis
    keewis committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    b626511 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2021

  1. Update doc/whats-new.rst 

    Co-authored-by: Mathias Hauser <mathause@users.noreply.github.com>
    @keewis @mathause
    keewis and mathause committed Feb 28, 2021
    Configuration menu
    Copy the full SHA
    5cba3e0 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2021

  1. Merge branch 'master' into raise-for-axis

    @keewis
    keewis committed Mar 3, 2021
    Configuration menu
    Copy the full SHA
    a95ce36 View commit details
    Browse the repository at this point in the history