Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raise on passing axis to Dataset.reduce methods #4940

Merged
merged 8 commits into from
Mar 4, 2021
Merged

raise on passing axis to Dataset.reduce methods #4940

merged 8 commits into from
Mar 4, 2021

Conversation

keewis
Copy link
Collaborator

@keewis keewis commented Feb 21, 2021 •
edited
Loading

@keewis
Copy link
Collaborator Author

keewis commented Feb 21, 2021

it seems Dataset.argmin / Dataset.argmax explicitly pass axis to reduce, so we would need to deprecate arg*'s axis kwarg first.

@keewis
Copy link
Collaborator Author

keewis commented Feb 25, 2021

since axis on Dataset reduce methods doesn't make sense, I simply removed the parameter of argmin / argmax

mathause
mathause approved these changes Feb 28, 2021
View reviewed changes
Copy link
Collaborator

@mathause mathause left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

doc/whats-new.rst Outdated Show resolved Hide resolved
@keewis @mathause
Update doc/whats-new.rst
5cba3e0 
Co-authored-by: Mathias Hauser <mathause@users.noreply.github.com>
@keewis keewis merged commit 66acafa into pydata:master Mar 4, 2021
@keewis keewis deleted the raise-for-axis branch March 4, 2021 00:45
dcherian added a commit to dcherian/xarray that referenced this pull request Mar 8, 2021
@dcherian
Merge remote-tracking branch 'upstream/master' into fix/4107
3f04332 
* upstream/master: (46 commits)
  pin netCDF4=1.5.3 in min-all-deps (pydata#4982)
  fix matplotlib errors for single level discrete colormaps (pydata#4256)
  Adapt exception handling in CFTimeIndex.__sub__ and __rsub__ (pydata#5006)
  Update options.py (pydata#5000)
  Adjust tests to use updated pandas syntax for offsets (pydata#4537)
  add a combine_attrs parameter to Dataset.merge (pydata#4895)
  Support for dask.graph_manipulation (pydata#4965)
  raise on passing axis to Dataset.reduce methods (pydata#4940)
  Whatsnew for 0.17.1 (pydata#4963)
  Refinements to how-to-release (pydata#4964)
  DOC: add example for reindex (pydata#4956)
  DOC: rm np import (pydata#4949)
  Add 0.17.0 release notes (pydata#4953)
  document update as inplace (pydata#4932)
  bump the dependencies (pydata#4942)
  Upstream CI: limit runtime (pydata#4946)
  typing for numpy 1.20 (pydata#4878)
  Use definition of DTypeLike from Numpy if found (pydata#4941)
  autoupdate mypy (pydata#4943)
  Add DataArrayCoarsen.reduce and DatasetCoarsen.reduce methods (pydata#4939)
  ...
@tomwhite tomwhite mentioned this pull request Mar 8, 2021
Closed
tomwhite added a commit to tomwhite/sgkit that referenced this pull request Mar 8, 2021
@tomwhite
Fix against xarray upstream due to pydata/xarray#4940
07bc5d9
tomwhite added a commit to tomwhite/sgkit that referenced this pull request Mar 8, 2021
@tomwhite
Fix against xarray upstream due to pydata/xarray#4940 sgkit-dev#477
9074c04
tomwhite added a commit to tomwhite/sgkit that referenced this pull request Mar 8, 2021
@tomwhite
Fix against xarray upstream due to pydata/xarray#4940 sgkit-dev#477
1a02ccb
mergify bot pushed a commit to sgkit-dev/sgkit that referenced this pull request Mar 8, 2021
@tomwhite @mergify
Fix against xarray upstream due to pydata/xarray#4940 #477
52b0716
dcherian added a commit to dcherian/xarray that referenced this pull request Mar 18, 2021
@dcherian
Merge remote-tracking branch 'upstream/master' into rolling-sliding-w…
517f1f0 
…indow

* upstream/master:
  add polyval to polyfit see also (pydata#5020)
  mention map_blocks in the docstring of apply_ufunc (pydata#5011)
  Switch backend API to v2 (pydata#4989)
  WIP: add new backend api documentation (pydata#4810)
  pin netCDF4=1.5.3 in min-all-deps (pydata#4982)
  fix matplotlib errors for single level discrete colormaps (pydata#4256)
  Adapt exception handling in CFTimeIndex.__sub__ and __rsub__ (pydata#5006)
  Update options.py (pydata#5000)
  Adjust tests to use updated pandas syntax for offsets (pydata#4537)
  add a combine_attrs parameter to Dataset.merge (pydata#4895)
  Support for dask.graph_manipulation (pydata#4965)
  raise on passing axis to Dataset.reduce methods (pydata#4940)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcherian dcherian dcherian approved these changes

@mathause mathause mathause approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Calling Dataset.mean() drops coordinates
3 participants
@keewis @dcherian @mathause