Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upstream CI: limit runtime #4946

Merged
merged 8 commits into from
Feb 23, 2021
Merged

Upstream CI: limit runtime #4946

merged 8 commits into from
Feb 23, 2021

Conversation

mathause
Copy link
Collaborator

Try to limit the time of "CI Upstream" to avoid a silent failure.

@mathause mathause changed the title Upstream max 5h Upstream CI: limit runtime Feb 23, 2021
@keewis
Copy link
Collaborator

keewis commented Feb 23, 2021

you can probably limit that to 1.5h or 2h: our CI currently takes about 30 minutes to run so if it suddenly takes more than double there is something wrong, anyway

@keewis
Copy link
Collaborator

keewis commented Feb 23, 2021

I seem to have misunderstood the purpose of --timeout: as far as I can tell, if a single test takes more than the value passed to it, a Failed instance is raised. As we don't have tests that should run more than 30s (I think?), we can safely set it to 2min.

@keewis
Copy link
Collaborator

keewis commented Feb 23, 2021 •
edited
Loading

The test status becomes ERROR, so the parsing script will not collect those. To fix that, could you also change

xarray/.github/workflows/parse_logs.py

Line 21 in 0f65307

lambda l: l.startswith("FAILED"), up_to_section_content
to

        lambda l: l.startswith("FAILED") or l.startswith("ERROR"), up_to_section_content

@mathause
Copy link
Collaborator Author

The timeout seems to work. If there are too many tests that take long the solution might not help but for the current problem it seems to be fine. I am merging so we catch the Upstream dev run in 1.5 h to see if the test now fails successfully ;-)

@mathause mathause merged commit df052e7 into pydata:master Feb 23, 2021
@mathause mathause deleted the upstream_max_5h branch February 23, 2021 22:37
@mathause mathause mentioned this pull request Feb 24, 2021
Closed
@mathause
Copy link
Collaborator Author

Thanks for the reviews @keewis

dcherian added a commit to dcherian/xarray that referenced this pull request Mar 8, 2021
@dcherian
Merge remote-tracking branch 'upstream/master' into fix/4107
3f04332 
* upstream/master: (46 commits)
  pin netCDF4=1.5.3 in min-all-deps (pydata#4982)
  fix matplotlib errors for single level discrete colormaps (pydata#4256)
  Adapt exception handling in CFTimeIndex.__sub__ and __rsub__ (pydata#5006)
  Update options.py (pydata#5000)
  Adjust tests to use updated pandas syntax for offsets (pydata#4537)
  add a combine_attrs parameter to Dataset.merge (pydata#4895)
  Support for dask.graph_manipulation (pydata#4965)
  raise on passing axis to Dataset.reduce methods (pydata#4940)
  Whatsnew for 0.17.1 (pydata#4963)
  Refinements to how-to-release (pydata#4964)
  DOC: add example for reindex (pydata#4956)
  DOC: rm np import (pydata#4949)
  Add 0.17.0 release notes (pydata#4953)
  document update as inplace (pydata#4932)
  bump the dependencies (pydata#4942)
  Upstream CI: limit runtime (pydata#4946)
  typing for numpy 1.20 (pydata#4878)
  Use definition of DTypeLike from Numpy if found (pydata#4941)
  autoupdate mypy (pydata#4943)
  Add DataArrayCoarsen.reduce and DatasetCoarsen.reduce methods (pydata#4939)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keewis keewis keewis left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathause @keewis