Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

preserve vlen string dtypes, allow vlen string fill_values #7869

Merged
merged 5 commits into from
Nov 17, 2023
Merged

preserve vlen string dtypes, allow vlen string fill_values #7869

merged 5 commits into from
Nov 17, 2023

Conversation

kmuehlbauer
Copy link
Contributor

@kmuehlbauer kmuehlbauer commented May 23, 2023 •
edited
Loading

@kmuehlbauer kmuehlbauer mentioned this pull request May 23, 2023
Closed
@kmuehlbauer kmuehlbauer marked this pull request as ready for review September 20, 2023 07:48
@kmuehlbauer
Copy link
Contributor Author

Resurrected this PR, rebased on latest main and force-pushed.

@kmuehlbauer
Copy link
Contributor Author

So, the h5netcdf-part does only work for versions h5py >= 3.7 and h5netcdf >= 1.1.0 (this fails for the 3.9 min deps). How can I account for that? Is there some best-practice?

@kmuehlbauer
Copy link
Contributor Author

So, the h5netcdf-part does only work for versions h5py >= 3.7 and h5netcdf >= 1.1.0 (this fails for the 3.9 min deps). How can I account for that? Is there some best-practice?

We are already unblocked for the h5py-version as the minimum dependency version is already at 3.7. h5netcdf get's unblocked on November, 23rd (in two month's time).

Should we just wait it out and make vlen strings available in one block?

@dcherian
Copy link
Contributor

h5netcdf get's unblocked on November, 23rd

I'm OK with bumping it early for this. If you want we could wait till after the next release to bring it down to one month :)

@kmuehlbauer
Copy link
Contributor Author

I'm OK with bumping it early for this. If you want we could wait till after the next release to bring it down to one month :)

Yes, wait until after next release and bump early.

@github-actions github-actions bot added CI Continuous Integration tools dependencies Pull requests that update a dependency file labels Nov 16, 2023
@kmuehlbauer kmuehlbauer reopened this Nov 17, 2023
@kmuehlbauer
Copy link
Contributor Author

@dcherian Finally, I think this is ready.

@dcherian
Copy link
Contributor

Thanks @kmuehlbauer

@dcherian dcherian merged commit 74901af into pydata:main Nov 17, 2023
51 of 53 checks passed
dcherian added a commit to rabernat/xarray that referenced this pull request Nov 29, 2023
@dcherian
Merge branch 'main' into fix-zarr-append
8cdce90 
* main:
  [skip-ci] dev whats-new (pydata#8467)
  2023.11.0 Whats-new (pydata#8461)
  migrate the other CI to python 3.11 (pydata#8416)
  preserve vlen string dtypes, allow vlen string fill_values (pydata#7869)
  Pin mypy < 1.7 (pydata#8458)
  Fix typos found by codespell (pydata#8457)
  [skip-ci] Small updates to IO docs. (pydata#8452)
  Deprecate certain cftime frequency strings following pandas (pydata#8415)
  Added driver parameter for h5netcdf (pydata#8360)
  Raise exception in to_dataset if resulting variable is also the name of a coordinate (pydata#8433)
  Automatic region detection and transpose for `to_zarr()` (pydata#8434)
  remove `cdms2` (pydata#8441)
  Remove PseudoNetCDF (pydata#8446)
  Pin pint to >=0.22 (pydata#8445)
  Remove keep_attrs from resample signature (pydata#8444)
  Rename `to_array` to `to_dataarray` (pydata#8438)
  Add missing DataArray.dt.total_seconds() method (pydata#8435)
  Declare Dataset, DataArray, Variable, GroupBy unhashable (pydata#8392)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcherian dcherian dcherian left review comments

Assignees
No one assigned
Labels
CI Continuous Integration tools dependencies Pull requests that update a dependency file io topic-backends topic-CF conventions
Projects
None yet
Milestone
No milestone
2 participants
@kmuehlbauer @dcherian