Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin pint to >=0.22 #8445

Merged
merged 8 commits into from
Nov 13, 2023
Merged

Pin pint to >=0.22 #8445

merged 8 commits into from
Nov 13, 2023

Conversation

dcherian
Copy link
Contributor

@dcherian dcherian commented Nov 12, 2023 •
edited
Loading

We were previously pinned to <0.21
Removing the pin didn't change the env but with >=0.21 we get 0.22 which works.

@github-actions github-actions bot added CI Continuous Integration tools dependencies Pull requests that update a dependency file labels Nov 12, 2023
@dcherian dcherian mentioned this pull request Nov 12, 2023
Open
@keewis
Copy link
Collaborator

keewis commented Nov 12, 2023

That's weird, is there another library that pins pint?

If we merge this it should close #7971 in addition to #8437.

@dcherian dcherian changed the title unpin pint Pin pint to >=0.22 Nov 12, 2023
@dcherian
Copy link
Contributor Author

I bumped the min-deps version too, seems like many things have been fixed since 0.19

@dcherian dcherian marked this pull request as ready for review November 12, 2023 21:58
@dcherian dcherian requested a review from keewis November 12, 2023 21:58
keewis
keewis approved these changes Nov 12, 2023
View reviewed changes
Copy link
Collaborator

@keewis keewis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mypy looks unrelated

@max-sixty
Copy link
Collaborator

I'll hit the button if that's OK!

@max-sixty max-sixty merged commit 0c1ad54 into main Nov 13, 2023
44 of 48 checks passed
@max-sixty max-sixty deleted the remove-pint-pin branch November 13, 2023 19:39
dcherian added a commit to rabernat/xarray that referenced this pull request Nov 29, 2023
@dcherian
Merge branch 'main' into fix-zarr-append
8cdce90 
* main:
  [skip-ci] dev whats-new (pydata#8467)
  2023.11.0 Whats-new (pydata#8461)
  migrate the other CI to python 3.11 (pydata#8416)
  preserve vlen string dtypes, allow vlen string fill_values (pydata#7869)
  Pin mypy < 1.7 (pydata#8458)
  Fix typos found by codespell (pydata#8457)
  [skip-ci] Small updates to IO docs. (pydata#8452)
  Deprecate certain cftime frequency strings following pandas (pydata#8415)
  Added driver parameter for h5netcdf (pydata#8360)
  Raise exception in to_dataset if resulting variable is also the name of a coordinate (pydata#8433)
  Automatic region detection and transpose for `to_zarr()` (pydata#8434)
  remove `cdms2` (pydata#8441)
  Remove PseudoNetCDF (pydata#8446)
  Pin pint to >=0.22 (pydata#8445)
  Remove keep_attrs from resample signature (pydata#8444)
  Rename `to_array` to `to_dataarray` (pydata#8438)
  Add missing DataArray.dt.total_seconds() method (pydata#8435)
  Declare Dataset, DataArray, Variable, GroupBy unhashable (pydata#8392)
This was linked to issues Feb 26, 2024
Pint errors on python 3.11 and windows #7971
Closed
Restrict pint test runs #8437
Open
@keewis keewis mentioned this pull request Feb 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keewis keewis keewis approved these changes

Assignees
No one assigned
Labels
CI Continuous Integration tools dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Restrict pint test runs Pint errors on python 3.11 and windows
3 participants
@dcherian @keewis @max-sixty