Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing chunkmanager: update error message #8803

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

mathause
Copy link
Collaborator

@mathause mathause commented Mar 1, 2024

When dask is missing we get the following error message:

ValueError: unrecognized chunk manager dask - must be one of: []

this could be confusing - the error message seems geared towards a typo in the requested manager. However, I think it's much more likely that a chunk manager is just not installed. I tried to update the error message - happy to get feedback.

@mathause mathause requested a review from TomNicholas March 1, 2024 15:48
@TomNicholas
Copy link
Member

I swear to god we already had an issue / PR about exactly this somewhere (I think with @dcherian ?), but now I can't find it.

Regardless, I think your change does clarify the error.

@TomNicholas TomNicholas added the topic-chunked-arrays Managing different chunked backends, e.g. dask label Mar 1, 2024
@kmuehlbauer
Copy link
Contributor

#8736 this? @TomNicholas

@mathause
Copy link
Collaborator Author

mathause commented Mar 1, 2024

Or #7963?

@mathause
Copy link
Collaborator Author

I would like to merge this but after checking #7963 and #8301 I am a bit confused.

  • Should I update the error message to accommodate for the "second chunk manager" (#8301 (comment))?
  • If so what is the "second chunk manager"?
  • Here I update the error message in guess_chunkmanager while #7963 updates the error message in get_chunked_array_type. Without knowing all the details I think it's more likely to run into the error in guess_chunkmanager (because to trigger the error in get_chunked_array_type there already needs to be a 'chunked array').

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic-chunked-arrays Managing different chunked backends, e.g. dask
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants