-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
friendlier error messages for missing chunk managers #9676
Conversation
Much better! |
Thanks - I had a PR on this but don't mind closing mine in favor of this one. There is also #7963 which seems related. |
wow, I don't know how I missed two open PRs that aim to do something similar in different ways. Which one do we take? If we merge this one your PR might still be valuable since it also changes the error message if there are chunk managers but not the one that was requested. |
Shall we merge? |
Sorry for dropping the ball on reviewing / merging these guys 😞 Let's merge this one.
This change would also be useful but is much less likely to come up. |
Co-authored-by: Tom Nicholas <tom@cworthy.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this could be further improved in cases like cubed being installed but dask not (when there would not be 0 chunkmanagers installed), this PR on it's own addresses the confusing error that 99% of users are encountering so should be merged asap.
we probably also want to prefer the more specific error over the generic |
@dcherian, @TomNicholas, this should be ready for a final review ( |
we can always release more! |
the failing |
for more information, see https://pre-commit.ci
@keewis I made some very minor changes - feel free to merge this. |
sorry for letting this stagnate for a month, I've been busy. I'll merge this tomorrow, should anyone be around and wish to review one final time. |
The current error message when trying to use a chunked-array related method without actually having a chunk manager available is:
That's pretty confusing, so this catches the case where no chunk manager is available and raises an error with guidance on how to fix that.
whats-new.rst