Avoid expensive list/tuple multiplication operations #2228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2228 +/- ##
=======================================
Coverage 92.93% 92.93%
=======================================
Files 95 95
Lines 10921 10924 +3
=======================================
+ Hits 10149 10152 +3
Misses 772 772
Flags with carried forward coverage won't be shown. Click here to find out more.
|
DanielNoord
requested changes
Jun 27, 2023
astroid/protocols.py
Outdated
| @@ -167,6 +167,9 @@ def _multiply_seq_by_int( | |||
| context: InferenceContext, | |||
| ) -> _TupleListNodeT: | |||
| node = self.__class__(parent=opnode) | |||
| if isinstance(other.value, int) and other.value > 1e8: | |||
| node.elts = [nodes.Const(NotImplemented)] | |||
There was a problem hiding this comment.
Shouldn't this be Uninferable instead of NotImplemented ?
There was a problem hiding this comment.
I suppose that's better than implying there's one element in the list.
DanielNoord
previously approved these changes
Jun 28, 2023
jacobtylerwalls
commented
Jun 28, 2023
jacobtylerwalls
commented
Jun 28, 2023
DanielNoord
approved these changes
Jun 30, 2023
Pierre-Sassoulas
approved these changes
Jun 30, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Jun 30, 2023
(cherry picked from commit 1a318a0)
jacobtylerwalls
added a commit
that referenced
this pull request
Jul 1, 2023
Pierre-Sassoulas
added
backported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Closes pylint-dev/pylint#8748
Similar approach to #1610, instead of adding this guard to
safe_infer, since it seems better to catch this as close to the source as possible instead of all of the places that callinfer().