change the type annotation error heuristic #2583
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2583 +/- ##
==========================================
+ Coverage 93.10% 93.24% +0.13%
==========================================
Files 93 93
Lines 11065 11067 +2
==========================================
+ Hits 10302 10319 +17
+ Misses 763 748 -15
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Thank you for the dive into the internal, much appreciated. Do you think it's possible to start testing this @temyurchenko ? I expected the coverage to go up but it wasn't tested before which explain that the dead code using a dead library is still there.
I'll try to add a test |
temyurchenko
force-pushed
the
fix-type-anno-heuristic
branch
from
2074d00
to
547b56f
Compare
The previous one depended on the message from "typed_ast", which is not used anymore. Instead, we check if there is a "# type:" substring in the source line of the exception. This can yield some false positives, but probably rarely.
temyurchenko
force-pushed
the
fix-type-anno-heuristic
branch
from
547b56f
to
7266e22
Compare
I've added a test and unblocked another one. It seems to have fixed pylint-dev/pylint#3757 and possibly pylint-dev/pylint#3556. |
The previous one depended on the message from "typed_ast", which is not used anymore. Instead, we check if there is a "# type:" substring in the source line of the exception. This can yield some false positives, but probably rarely. (cherry picked from commit 62c5bad)
The previous one depended on the message from "typed_ast", which is not used anymore. Instead, we check if there is a "# type:" substring in the source line of the exception. This can yield some false positives, but probably rarely. (cherry picked from commit 62c5bad) Co-authored-by: temyurchenko <44875844+temyurchenko@users.noreply.github.com>
The previous one depended on the message from "typed_ast", which is
not used anymore.
Instead, we check if there is a "# type:" substring in the source line
of the exception. This can yield some false positives, but probably
rarely.
Description
Partially addresses pylint-dev/pylint#3757