Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python3.9 support #382

Merged
merged 12 commits into from
Sep 7, 2020
Merged

Add python3.9 support #382

merged 12 commits into from
Sep 7, 2020

Conversation

joerick
Copy link
Contributor

@joerick joerick commented Jun 22, 2020

Python 3.9 is in beta, and not yet ABI stable, so you shouldn't publish wheels with it yet.

But if you want to check that your wheels build on Python 3.9, try this python3.9 branch!

To try this branch, in your CI config, replace

pip install cibuildwheel==?.?.?

with

pip install git+https://github.com/joerick/cibuildwheel.git@python3.9

fruch added a commit to fruch/python-driver that referenced this pull request Jul 23, 2020
fruch added a commit to fruch/python-driver that referenced this pull request Jul 23, 2020
@fruch
Copy link

fruch commented Jul 23, 2020

@joerick thanks a lot, I'm taking this one for a test drive, when is the plan to merge this ?, only in October when python3.9 would be released formally ?

@joerick
Copy link
Contributor Author

joerick commented Jul 23, 2020

The credit's @YannickJadoul's! We'll be merging this once Python3.9 is ABI stable, which is the first release candidate I believe.

fruch added a commit to fruch/python-driver that referenced this pull request Jul 23, 2020
base on this draft PR/branch
pypa/cibuildwheel#382

currently skipping windows for python3.9, since the
tests are not working
fruch added a commit to fruch/python-driver that referenced this pull request Jul 23, 2020
base on this draft PR/branch
pypa/cibuildwheel#382

currently skipping windows for python3.9, since the
tests are not working
fruch added a commit to scylladb/python-driver that referenced this pull request Jul 23, 2020
base on this draft PR/branch
pypa/cibuildwheel#382

currently skipping windows for python3.9, since the
tests are not working
@YannickJadoul
Copy link
Member

Might be worth rebasing onto 1.5.5, though?

@joerick
Copy link
Contributor Author

joerick commented Jul 24, 2020

Might be worth rebasing onto 1.5.5, though?

Good point, I'll get on that

@joerick
Copy link
Contributor Author

joerick commented Jul 24, 2020

Also, Python 3.9.0b5 is out, we should update to that once manylinux gets it pypa/manylinux#682

@YannickJadoul
Copy link
Member

Hurraaaaay, 3.9 rc1! Almost there, except for pypa/manylinux#710!

If this also works, what's the plan, then, @joerick? Do you want to push a release soon and then later have another patch release when 3.9 officially gets release?

@YannickJadoul
Copy link
Member

Only manylinux2014 on ppc64le is missing. Apparently Travis's ppc64le build is acting up.

@joerick
Copy link
Contributor Author

joerick commented Aug 13, 2020

from the announcement post on python-dev https://mail.python.org/archives/list/python-dev@python.org/thread/FFVG5DAE7RHE5ZYUVVJW5TPAZ2ALRFHB/

We strongly encourage maintainers of third-party Python projects to prepare
their projects for 3.9 compatibility during this phase. As always, report any issues to
the Python bug tracker https://bugs.python.org/.

Based on the above, I think we should be merging this PR and releasing a version of cibuildwheel that builds packages against 3.9.0rc1. It does make me wonder what happens if a bug is found, but I guess that's what the release candidate phase is for :)

Does anyone know if PyPI is accepting 3.9 wheels yet?

EDIT: it appears PyPI is accepting them - see https://pypi.org/project/scylla-driver/#files for an example

@YannickJadoul
Copy link
Member

Does anyone know if PyPI is accepting 3.9 wheels yet?

EDIT: it appears PyPI is accepting them - see https://pypi.org/project/scylla-driver/#files for an example

Ah, great, I tried looking, but couldn't immediately find one :-)

Anyhow, sure, as you think is best. ABI should be stable now, I suppose, so ... all that's missing is that ppc64le docker image, I suppose. But we could always update later?
(I only updated the docker images, btw, so maybe the constraints files should still be given an update as well?)

@joerick joerick marked this pull request as ready for review September 6, 2020 16:24
@joerick joerick changed the title Tracking PR for ongoing python3.9 branch Add python3.9 support Sep 6, 2020
@joerick
Copy link
Contributor Author

joerick commented Sep 6, 2020

Okie doke, I'll merge this soon and make a release. Do we need to worry about the missing ppc64le image, since it's still building with 3.9b3? I'm leaning towards just merging it, any potential issues would be unlikely.

@YannickJadoul
Copy link
Member

With a bit of luck, we'll soon enough have a PyPy release that fixes all our problems there, but I guess we shouldn't wait for that.

Worrying about ppc64le? I don't know. It's still not there, I think: https://quay.io/repository/pypa/manylinux2014_ppc64le?tab=tags
But I also don't know if Travis CI works again on that image. It seems it is, so I could try if it would build and make an empty PR to manylinux, if you want?

@YannickJadoul
Copy link
Member

But I also don't know if Travis CI works again on that image. It seems it is, so I could try if it would build and make an empty PR to manylinux, if you want?

Scratch that. I am actually trying: https://travis-ci.org/github/YannickJadoul/manylinux/builds/724689320
I'll create a PR if this works. Otherwise, we can just merge :-)

@YannickJadoul
Copy link
Member

OK, nevermind. Not such great news, from the ppc64le side: see pypa/manylinux#758. You can probably release, and we can add a patch when this gets fixed?

@YannickJadoul
Copy link
Member

@joerick Fixed some more things in the README. Tried to match #419 as closely as possible. Hopefully that will reduce the number of conflicts.

@joerick
Copy link
Contributor Author

joerick commented Sep 7, 2020

Fantastic, thank you @YannickJadoul for updating those. Including a note in the readme about ppc64le is a good idea. I'll also note it in the release notes.

@joerick joerick merged commit 8a434b1 into master Sep 7, 2020
@YannickJadoul YannickJadoul deleted the python3.9 branch September 7, 2020 21:04
fruch added a commit to fruch/python-driver that referenced this pull request Sep 9, 2020
Now that they merged PR for python3.9 support
and that branch is deleted, we should move back to
formal version

Ref: pypa/cibuildwheel#382
fruch added a commit to scylladb/python-driver that referenced this pull request Sep 9, 2020
Now that they merged PR for python3.9 support
and that branch is deleted, we should move back to
formal version

Ref: pypa/cibuildwheel#382
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants