Add option to silence warnings related to deprecation of Python versions

[victorvpaulo]

Implements #6673, Helps with #6231.
@pradyunsg

[victorvpaulo]

@pradyunsg All tests have passed. I think this is ready to be reviewed.

[chrahunt]

Hi @victorvpaulo, sorry it has taken so long to get feedback to you.

I have a few minor comments, and this will also need tests. I would create 3:

1. Test that warning shows up as expected - this should only run on CPython + Python 2
2. Test that warning does not show up anywhere else - this should run on not (CPython + Python 2)
3. Test that warning does not show up on CPython + Python 2 when the flag is passed.

For examples of checking pip output, please look at test_installing_scripts_outside_path_can_suppress_warning in tests/functional/test_install.py. We probably do not want to do a pip install since that can add some time to the overall test execution, but something like a pip debug should still cause the warning to print. I didn't see an existing test for this functionality submitted with the original change (#6147), so it can probably go in tests/functional/test_warning.py.

[chrahunt]

Not sure why GitHub is showing that all of these commits would be added. Can you rebase so your commit is the only one on top of the current master branch?

[victorvpaulo]

Not sure why GitHub is showing that all of these commits would be added. Can you rebase so your commit is the only one on top of the current master branch?

I'm sorry, i think i used merge instead of rebase to update my feature branch.
I will try to find some time next week to fix this mess and create the tests.

[uranusjr]

If suggestions are still possible, I’d wish the option name is more consistent with others. Some potential names I can think of are

• no-python-version-warning
• no-python-version-check
• disable-python-version-check (a la disable-pip-version-check)

The latter two have a slightly different sematic`, but I feel the current warning (and its implementation) is kind of like the pip version check.

[victorvpaulo]

If suggestions are still possible, I’d wish the option name is more consistent with others. Some potential names I can think of are

* `no-python-version-warning`

* `no-python-version-check`

* `disable-python-version-check` (a la `disable-pip-version-check`)

The latter two have a slightly different sematic`, but I feel the current warning (and its implementation) is kind of like the pip version check.

Hi, thank you for your suggestion.
I think no-python-version-warning is a good one.

[victorvpaulo]

@chrahunt I created the tests you specified and made the other necessary changes. I believe this is ready for review.

[chrahunt]

This looks good! I have a few minor comments. Can we also add one test passing --no-python-version-warning on not Python 2? We shouldn't need to actually check anything from the result for that one since the script helper already asserts the return code is zero and no stderr is output.

[victorvpaulo]

@chrahunt I think the latest commits address your points. I did some tests locally to ensure that the move of the skip decorators declarations to tests / lib / __ init __. Py did not break anything.

[chrahunt]

Thank you! Yes, I think it does.

[chrahunt]

Thanks again @victorvpaulo!

[victorvpaulo]

Thank you for your reviews @chrahunt. The guidance you provided is really important to a newbie oss contributor like me.