-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure auto-discovery does not break include_package_data
#3202
Conversation
And also avoid using './' paths
I confirmed this fixes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Yes I experienced the same trouble here locally when trying to test jupyter_server. Then after a workaround, I found some other problems related to Hopefully it will work. Thank you very much Steven for checking the PR! |
Haha good call, the bane of Jupyter-development. |
Sorry 😝, I promise I will get back to it soon. |
No worries, I'll double-check once a patch release is out. |
We already merged jupyter-server/jupyter_server#757 as a workaround anyway, but I'll make sure it works without that patch. |
Thank you very much for the help and the understanding. |
We have our CI pipelines broken because of this and while we are working on the fix on our side we are curious if there is an ETA for releasing this fix? |
Hi @kosteev, being optimistic, if Github actions/hooks don't go bad again I hope to get the first batch of fixes out still today (I am at UTC). |
Thank you! |
I had the same problem as the original issue (only affected Python 3.7 on GH Actions, couldn't reproduce locally). Anyway, I have tested this fix out by pip installing setuptools from the GH repo instead of PyPI and can confirm the problem is fixed 👍 (for me at least) |
v61.1.0 fixes the issue in |
This is an attempt to fix #3196
Summary of changes
package_dir
in flat-layouts./
inpackage_dir
Closes
Pull Request Checklist
changelog.d/
.(See documentation for details)