Obsolete IntegerValue property in Revit2024 and higher - Replaced by Value

[jmcouffin]

replaced by Value

https://discourse.pyrevitlabs.io/t/release-date-pyrevit-2025/3083/60?u=jean-marc

@acco-jpitts

[sanzoghenzo]

Can I offer a suggestion to avoid code repetition?

value_func  = lambda x: x.Value if HOST_APP.is_newer_than(2023) else x.IntegerValue

or a more verbose, but maybe clearer, function to put in compat.py

def get_value_func():
    def get_value_2024(item):
        return item.Value

    def get_value_2003(item):
        return item.IntegerValue

    return get_value_2024 if HOST_APP.is_newer_than(2023) else get_value_2003

so that one can do, for example

value_func = get_value_func()
sheet_revids = {value_func(x) for x in self.revit_sheet.GetAllRevisionIds()}
add_sheet_revids = {value_func(x) for x in self.revit_sheet.GetAdditionalRevisionIds()}

[jmcouffin]

Great advice @sanzoghenzo
As always.
I did not overthink the thing, I just did the mods over lunch.
I will implement your 2nd suggestion

[sanzoghenzo]

This is not properly in-scope, but while you're at it.... 😉

[sanzoghenzo]

Just a question: why there were lines like if cat.Id.IntegerValue == cat_id.IntegerValue?

I'm not a Revit API guru, but I expect that cat.Id == cat_id would do just fine and save some CPU time in the python side of things...

Obviously I don't have the full picture, and I didn't check it, but I can see the Equals operator for ElementId in revitapidocs

[jmcouffin]

@sanzoghenzo would you mind having a quick look.
My eyes are sore editing 46 files with dumb changes like this.
I had to stop looking and just do the thing as there are so many coding styles and bad practices in so many tools 🤣

[jmcouffin]

I may have broken a thing or two. Time will tell.
A common pattern that bothers me is the ElementId comparison to -1 instead of

if isinstance(element, DB.ElementId.InvalidElementId):

[sanzoghenzo]

You did a hell of a job!

some of the variables are enum items, so we should use the value to compare them.
I suggested only one place in which to use DB.ElementId.InvalidElementId (it's not a type so we should use comparison operators and not isinstance), but there may be other places it can be used.

[sanzoghenzo]

Argh, I was going to suggest you to do a merge with squash to avoid all those commits in the git log 😅

It's getting harder and harder browse the commit history with all those single file commits....

[github-actions]

📦 New work-in-progress (wip) builds are available for 5.0.0.24242+0910-wip

[github-actions]

📦 New work-in-progress (wip) builds are available for 5.0.0.24246+1410-wip

[sanzoghenzo]

Did you test this PR? It is broken since you used __revit__.Application.is_newer_than, but the Revit Application class doesn't have that method. You need to use HOST_APP.is_newer_than to make it work.

I'll fix it after lunch

[jmcouffin]

Did you test this PR?
I haven't
I guess HOST_APP won't cut it either as it is initiated in the init, right? Inception situation?
something like __revit__.Application.VersionNumber > 2023 should work

[jmcouffin]

and for the sake of documentation, this release works in 2025 but not in 2024 and below

[sanzoghenzo]

That error is the one I'm trying to fix on my PR 😉

I'll factor out the version number retrieval from the is_netcore to use it for this function, too.

[jmcouffin]

I'll fix it after lunch

You were not kidding! @sanzoghenzo Nice!

[github-actions]

📦 New work-in-progress (wip) builds are available for 5.0.0.24253+1920-wip

[github-actions]

📦 New work-in-progress (wip) builds are available for 5.0.0.24254+1158-wip

[github-actions]

📦 New work-in-progress (wip) builds are available for 5.0.0.24254+1351-wip

[github-actions]

📦 New work-in-progress (wip) builds are available for 5.0.0.24261+0647-wip