Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEST: turning off 3.6 on github actions #266

Closed
wants to merge 2 commits into from
Closed

Conversation

sjsrey
Copy link
Member

@sjsrey sjsrey commented Mar 25, 2020

3.6 job grabs an older version of geopandas which is causing the voronoi tests to fail (those pass on 3.6 on travis).

@AppVeyorBot
Copy link

Build libpysal 1.0.57 completed (commit e9f4b95c03 by @sjsrey)

@codecov
Copy link

codecov bot commented Mar 25, 2020

Codecov Report

Merging #266 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #266   +/-   ##
=======================================
  Coverage   81.02%   81.02%           
=======================================
  Files         116      116           
  Lines       11574    11574           
=======================================
  Hits         9378     9378           
  Misses       2196     2196           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dbcaf2...632a6e9. Read the comment docs.

@AppVeyorBot
Copy link

Build libpysal 1.0.60 completed (commit a1bef93b98 by @sjsrey)

Copy link
Member

@jGaboardi jGaboardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWI, I have the working on a complete solution with GitHub Actions in spaghetti and it seems like success is just around the corner.

Complete solution (pysal/spaghetti/pull/452):

  • tests ubuntu, mac, windows
  • tests Python 3.6, 3.7, 3.8
  • tests both hard and optional requirements
  • tests with both the current libpysal release and the current master
  • performs code-cov
  • run nightly tests

Once this is fully worked out, spaghetti will be able to migrate off of Travis and Appveyor.

@sjsrey
Copy link
Member Author

sjsrey commented Mar 28, 2020

will be handled in #267

@sjsrey sjsrey closed this Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants