-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initializing complete Github Actions CI #267
Conversation
Once this PR is agreed on we can:
|
✅ Build libpysal 1.0.64 completed (commit 1a3fcb92c8 by @jGaboardi) |
This PR is good to go. Travis hasn't been communicating well with GitHub this week (see here), hence the Pending build. |
Will look at this in detail tomorrow. Thanks! |
Codecov Report
@@ Coverage Diff @@
## master #267 +/- ##
=======================================
Coverage 81.02% 81.02%
=======================================
Files 116 116
Lines 11574 11574
=======================================
Hits 9378 9378
Misses 2196 2196 Continue to review full report at Codecov.
|
Can you link to instructions on codecov? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
|
Are you doing a PR for these next steps? I'm happy to do it but don't want to duplicate |
Yes, I will do the PR in a bit (I like to do these kind of PRs) 😬 Sent with GitHawk |
This PR proposes a complete solution for CI with GitHub Actions based on that of
spaghetti
's. This workflow allows for the following (from a single.yml
with a single service):codecov
Currently,
codecov
is enabled after the unit tests run. In order for this to function properly, someone with admin privileges will have to put thecodecov
token in the Settings/Secrets/ folder. A token is not needed with Travis or Appveyor, but it is currently needed for GH Actions.Related to #264
See also: pysal/spaghetti#452 and pysal/spaghetti#453