Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initializing complete Github Actions CI #267

Merged
merged 1 commit into from
Mar 28, 2020
Merged

Initializing complete Github Actions CI #267

merged 1 commit into from
Mar 28, 2020

Conversation

jGaboardi
Copy link
Member

This PR proposes a complete solution for CI with GitHub Actions based on that of spaghetti's. This workflow allows for the following (from a single .yml with a single service):

  • tests Ubuntu, Mac, Windows
  • tests Python 3.6, 3.7, 3.8
  • performs codecov
  • run nightly tests
  • negates dual dependency on Travis and Appveyor for testing
  • all tests run concurrently reducing overall time for testing dramatically, especially with Appveyor/Windows tests

Currently, codecov is enabled after the unit tests run. In order for this to function properly, someone with admin privileges will have to put the codecov token in the Settings/Secrets/ folder. A token is not needed with Travis or Appveyor, but it is currently needed for GH Actions.

Related to #264

See also: pysal/spaghetti#452 and pysal/spaghetti#453

@jGaboardi jGaboardi self-assigned this Mar 27, 2020
@jGaboardi
Copy link
Member Author

jGaboardi commented Mar 27, 2020

Once this PR is agreed on we can:

  • remove .github/workflows/test-conda.yml and .github/workflows/test-push.yml
  • move and rename environments from ci/travis/...yml to ci/...yml
  • remove .travis.yml and appveyor.yml
  • disable Travis CI and Appeyor
  • edit badges in README.rst

@jGaboardi jGaboardi requested a review from sjsrey March 27, 2020 20:23
@AppVeyorBot
Copy link

Build libpysal 1.0.64 completed (commit 1a3fcb92c8 by @jGaboardi)

@jGaboardi
Copy link
Member Author

This PR is good to go. Travis hasn't been communicating well with GitHub this week (see here), hence the Pending build.

@sjsrey
Copy link
Member

sjsrey commented Mar 27, 2020

Will look at this in detail tomorrow. Thanks!

@codecov
Copy link

codecov bot commented Mar 27, 2020

Codecov Report

Merging #267 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #267   +/-   ##
=======================================
  Coverage   81.02%   81.02%           
=======================================
  Files         116      116           
  Lines       11574    11574           
=======================================
  Hits         9378     9378           
  Misses       2196     2196           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dbcaf2...3cb7558. Read the comment docs.

@sjsrey
Copy link
Member

sjsrey commented Mar 28, 2020

This PR proposes a complete solution for CI with GitHub Actions based on that of spaghetti's. This workflow allows for the following (from a single .yml with a single service):

* tests Ubuntu, Mac, Windows

* tests Python 3.6, 3.7, 3.8

* performs `codecov`

* run nightly tests

* negates dual dependency on Travis and Appveyor for testing

* all tests run concurrently reducing overall time for testing dramatically, especially with Appveyor/Windows tests

Currently, codecov is enabled after the unit tests run. In order for this to function properly, someone with admin privileges will have to put the codecov token in the Settings/Secrets/ folder. A token is not needed with Travis or Appveyor, but it is currently needed for GH Actions.

Related to #264

See also: pysal/spaghetti#452 and pysal/spaghetti#453

Can you link to instructions on codecov?

Copy link
Member

@sjsrey sjsrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@sjsrey sjsrey merged commit 0a84e81 into master Mar 28, 2020
@jGaboardi
Copy link
Member Author

Can you link to instructions on codecov?

@jGaboardi jGaboardi deleted the jGaboardi-patch-1 branch March 28, 2020 15:23
@jGaboardi jGaboardi mentioned this pull request Mar 28, 2020
5 tasks
@sjsrey
Copy link
Member

sjsrey commented Mar 28, 2020

Once this PR is agreed on we can:

* remove `.github/workflows/test-conda.yml` and `.github/workflows/test-push.yml`

* move and rename environments from `ci/travis/...yml` to `ci/...yml`

* remove `.travis.yml` and `appveyor.yml`

* disable Travis CI and Appeyor

* edit badges in `README.rst`

Are you doing a PR for these next steps? I'm happy to do it but don't want to duplicate

@jGaboardi
Copy link
Member Author

Yes, I will do the PR in a bit (I like to do these kind of PRs) 😬

Sent with GitHawk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants