initial SPGLM modernization #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jGaboardi
requested review from
knaaptime,
Ziqi-Li,
TaylorOshan,
martinfleis and
sjsrey
|
If I don't hear anything from yall on this in the next day, I will go ahead and merge to get the ball rolling on modernization. |
|
you have my blessing :D. note that it may nearly be time to include python 3.12 in the matrix |
baby steps, my boy. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an initial SPGLM modernization effort. In order for the GHA to be triggered here, this will need to be merged. However, we can see that tests are passing in all environments in
jGaboardi/spglm. If the minimum pins need adjusting, we can do so in subsequent PRs.