Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format repo with black #39

Merged
merged 3 commits into from
Oct 11, 2023
Merged

Format repo with black #39

merged 3 commits into from
Oct 11, 2023

Conversation

jGaboardi
Copy link
Member

  • This PR formats the repo with black
  • There are no actual code changes.
  • As with initial SPGLM modernization #36, If I don't hear anything back in the next day, I will go ahead and merge to get the ball rolling on modernization.

cc @Ziqi-Li @TaylorOshan @knaaptime @martinfleis @sjsrey

@jGaboardi jGaboardi self-assigned this Oct 11, 2023
@codecov
Copy link

codecov bot commented Oct 11, 2023

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

martinfleis
martinfleis approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@martinfleis martinfleis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, otherwise go ahead and merge once the CI passes.

notebooks/Binomial_GLM.ipynb Show resolved Hide resolved
@jGaboardi jGaboardi merged commit 7cffe56 into pysal:main Oct 11, 2023
6 of 8 checks passed
@jGaboardi jGaboardi deleted the 01_blacken_repo branch October 11, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinfleis martinfleis martinfleis approved these changes

@sjsrey sjsrey Awaiting requested review from sjsrey

@knaaptime knaaptime Awaiting requested review from knaaptime

@Ziqi-Li Ziqi-Li Awaiting requested review from Ziqi-Li

@TaylorOshan TaylorOshan Awaiting requested review from TaylorOshan

Assignees

@jGaboardi jGaboardi

Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jGaboardi @martinfleis