Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure compat with xdist 2.0+ #18

Merged
merged 1 commit into from
Jul 8, 2020
Merged

Ensure compat with xdist 2.0+ #18

merged 1 commit into from
Jul 8, 2020

Conversation

Zac-HD
Copy link
Member

@Zac-HD Zac-HD commented Jun 17, 2020

Fixes #17; see pytest-dev/pytest-xdist#541 for background.


This change is Reviewable

@Zac-HD Zac-HD requested review from bubenkoff and dasm June 17, 2020 13:25
@coveralls
Copy link

coveralls commented Jun 17, 2020

Coverage Status

Coverage remained the same at 58.197% when pulling 9276307 on emancipate into e06fec1 on master.

Copy link
Member

@bubenkoff bubenkoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please bump the version requirement for xdist accordingly
also, this should be a major release
and when you add a changelog record, don't assume the release already, this IMO should be done as part of the release process, so we keep unreleased changes under Unreleased instead of the number

@Zac-HD
Copy link
Member Author

Zac-HD commented Jun 17, 2020

This is compatible back to pytest-xdist 1.22.3, which is older than the current minimum requirement 🙂

It's therefore an entirely internal change - this is an implementation detail which doesn't change any public API or dependencies, just ensures that users can upgrade pytest-xdist without breaking pytest-cloud.

@bubenkoff
Copy link
Member

@Zac-HD then why the tests didn't fail before? then we should make sure that it's covered

@Zac-HD
Copy link
Member Author

Zac-HD commented Jun 17, 2020

The new version of xdist hasn't been released yet - I'm aiming to update all the major integrations first.

And it's definitely covered, we're just switching to use the newer of two identical attributes before the old one is removed - so it's a no-op change on current versions but will not break when the next version comes out.

@Zac-HD
Copy link
Member Author

Zac-HD commented Jun 30, 2020

@bubenkoff - I've fixed the changelog to list this as "Unreleased". If there's anything else I need to do before you can merge this, please let me know!

It's working at the moment but without this backwards-compatible patch pytest-cloud will break as soon as pytest-xdist 2 is released 😕

@bubenkoff
Copy link
Member

please merge with squashing
would you like to get the pypi permission to release it yourself, now and in the future?

@Zac-HD Zac-HD merged commit b2883fe into master Jul 8, 2020
@Zac-HD Zac-HD deleted the emancipate branch July 8, 2020 02:52
@Zac-HD
Copy link
Member Author

Zac-HD commented Jul 8, 2020

Thanks @bubenkoff!

While I appreciate the offer, I'm happy to leave the release process to someone more regularly involved. Personally I like to automate releases entirely, so that CI tries a twine upload if the build passes on master, so I'm seriously out of practice at any manual release process 😅

@bubenkoff
Copy link
Member

@Zac-HD if you're willing to help, let's automate it for this project?

@bubenkoff
Copy link
Member

5.0.0 is out

@Zac-HD
Copy link
Member Author

Zac-HD commented Jul 8, 2020

It's pretty easy! For hypothesis-jsonschema, here's the logic:

# to run in CI, on master, if tests pass:
python -m pip install --upgrade pip setuptools wheel twine
python setup.py sdist bdist_wheel && twine upload --skip-existing dist/*

And I wrote some tests to check that the version number and changelog are up to date too: https://github.com/Zac-HD/hypothesis-jsonschema/blob/master/tests/test_version.py

@bubenkoff
Copy link
Member

@Zac-HD great, are you interested in helping set it up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upcoming incompatibility in pytest-xdist 2.0: "slave" aliases removed
3 participants