-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure compat with xdist 2.0+ #18
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please bump the version requirement for xdist accordingly
also, this should be a major release
and when you add a changelog record, don't assume the release already, this IMO should be done as part of the release process, so we keep unreleased changes under Unreleased instead of the number
This is compatible back to It's therefore an entirely internal change - this is an implementation detail which doesn't change any public API or dependencies, just ensures that users can upgrade |
@Zac-HD then why the tests didn't fail before? then we should make sure that it's covered |
The new version of xdist hasn't been released yet - I'm aiming to update all the major integrations first. And it's definitely covered, we're just switching to use the newer of two identical attributes before the old one is removed - so it's a no-op change on current versions but will not break when the next version comes out. |
@bubenkoff - I've fixed the changelog to list this as "Unreleased". If there's anything else I need to do before you can merge this, please let me know! It's working at the moment but without this backwards-compatible patch |
please merge with squashing |
Thanks @bubenkoff! While I appreciate the offer, I'm happy to leave the release process to someone more regularly involved. Personally I like to automate releases entirely, so that CI tries a |
@Zac-HD if you're willing to help, let's automate it for this project? |
5.0.0 is out |
It's pretty easy! For # to run in CI, on master, if tests pass:
python -m pip install --upgrade pip setuptools wheel twine
python setup.py sdist bdist_wheel && twine upload --skip-existing dist/* And I wrote some tests to check that the version number and changelog are up to date too: https://github.com/Zac-HD/hypothesis-jsonschema/blob/master/tests/test_version.py |
@Zac-HD great, are you interested in helping set it up? |
Fixes #17; see pytest-dev/pytest-xdist#541 for background.
This change is