Remove deprecated "slave" aliases

[Zac-HD]

We started this process in 2017 with #234, and it's time to complete it. Xref pytest-dev/pytest#7344

Implementation note: after is in a released version of pytest, I'll bump the pytest required version for pytest-xdist and then merge this 🙂

• Merge Finish deprecation of "slave" pytest#7356 for upstream pytest support
• Bump minimum dependency version to pytest >= 6.0.0 (after that release)
• Fix other plugin compatibility issues linked below
  • PRs opened for all plugins
  • PRs merged for all plugins
  • Fix released for all plugins (mostly done, not treating this as a blocker)
• Merge this PR
• Release pytest-xdist 2.0 🎉

[Zac-HD]

And it looks like we'll need to start with some upstream fixes, and then bump the minimum version of pytest that pytest-xdist works with.

For future reference, if we're deprecating an attribute we should really turn it into a property which emits deprecation warnings so that people know they need to migrate - in this case even the pytest team seems to have missed it!

[RonnyPfannschmidt]

Lovely, thanks

[RonnyPfannschmidt]

Needs to be a major release 👍

[hugovk]

Some other pytest-dev repos that'll need updating:

https://github.com/search?l=Python&q=sort%3Aupdated-desc+slave+org%3Apytest-dev+xdist&type=Code

[nicoddemus]

Thanks @Zac-HD!

As you commented, we will need to update the requirements in setup.py to pytest>=6.0, and we will need
to release this only after pytest 6.0 is released. 👍

Just marking this as "requested changes" so it is clear this is not yet ready for merging.

[nicoddemus]

I've posted an issue to all repositories from @hugovk's search warning about the upcoming changes. 👍

[asottile]

for those looking for messaging, the minimum version necessary appears to be pytest-xdist 1.22.3

[asottile]

[Zac-HD]

I've bumped the dependency to pytest >= 6.0.0rc1, and everything works 🎉

@nicoddemus @RonnyPfannschmidt @asottile - the plan was to wait for 6.0.0 final, but I guess we could also do a pytest-xdist 2.0.0rc1 prerelease if users are installing preview versions at the moment?

[Zac-HD]

@nicoddemus (et al ❤️), pytest 6 is out 🎉 and I think we're finally ready to merge this!

Then merge #557 into master, and do the release magic...

was waiting for pytest 6.0, which is now out!

[hugovk]

All the issues/PRs referencing this one are now closed/merged 👍

[nicoddemus]

Hey everyone, sorry for the delay here; I did not forget this, it is on my radar, I will get to it sometime this week. 👍

[nicoddemus]

Merged! 🎉

Thanks a lot @Zac-HD, for implementing it here and the amazing work on pursuing/helping other plugins to get compatible, @hugovk for neatly cleaning up old Python 2.7 support (as he is prone to do! 😁), and everybody else who participated/helped.

[nicoddemus]

I want to take a pass at the opening PRs before releasing 2.0, will try to do it by the end of the week. 👍