Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pytest-xdist + pypy hanging on Travis-CI #131

Closed
nicoulaj opened this issue Mar 19, 2017 · 15 comments
Closed

pytest-xdist + pypy hanging on Travis-CI #131

nicoulaj opened this issue Mar 19, 2017 · 15 comments

Comments

@nicoulaj
Copy link

My tests don't start when using pytest-xdist on Travis CI with pypy/pypy3, crashing and restarting workers for 50 minutes before I cancelled it.
nicoulaj added a commit to nicoulaj/rainbow that referenced this issue Mar 19, 2017
@nicoulaj
#55: trying a workaround for pytest-dev/pytest-xdist#131 / pytest-dev…
267cf11 
…/pytest-xdist#9

Signed-off-by: Julien Nicoulaud <julien.nicoulaud@gmail.com>

# Veuillez saisir le message de validation pour vos modifications. Les lignes
# commençant par '#' seront conservées ; vous pouvez les supprimer vous-même
# si vous le souhaitez. Un message vide abandonne la validation.
#
# Date :       Sun Mar 19 13:49:16 2017 +0100
#
# Sur la branche master
# Votre branche et 'origin/master' ont divergé,
# et ont 1 et 1 commits différents chacune respectivement.
#   (utilisez "git pull" pour fusionner la branche distante dans la vôtre)
#
# Modifications qui seront validées :
#	modifié :         tox.ini
#
nicoulaj added a commit to nicoulaj/rainbow that referenced this issue Mar 19, 2017
@nicoulaj
#55: trying a workaround for pytest-dev/pytest-xdist#131 / pytest-dev…
9ba732f 
…/pytest-xdist#9

Signed-off-by: Julien Nicoulaud <julien.nicoulaud@gmail.com>
@RonnyPfannschmidt
Copy link
Member

this is indeed related to #9 travis reports wrong cpu counts to containers

@nicoddemus
Copy link
Member

I guess this can be close as duplicate then

@nicoulaj
Copy link
Author

It does not explain why it would hang with pypy, it still works fine with cPython even with 32 workers...

@RonnyPfannschmidt
Copy link
Member

RonnyPfannschmidt commented Mar 19, 2017 •
edited
Loading

@nicoulaj this may be a pypy bug then, i probably wont find the time to investigate this one

@liiight

This comment has been minimized.

Sign in to view
@nicoddemus

This comment has been minimized.

Sign in to view
@liiight

This comment has been minimized.

Sign in to view
@benoit-pierre benoit-pierre mentioned this issue Aug 12, 2017
Closed
@thedrow

This comment has been minimized.

Sign in to view
@nicoddemus
Copy link
Member

I think the original issue "pytest-xdist + pypy hanging on Travis-CI" has not been fixed yet, right?

@RonnyPfannschmidt
Copy link
Member

@nicoddemus the original issue seems to relate to the fundamentally broken node restart mechanism
as nodes restart things just keep breaking, thus ultimately timeouting the build

@nicoulaj please note that travis has completely broken reporting of available cpus and cant be trusted to provide correct data

@nicoddemus
Copy link
Member

the original issue seems to relate to the fundamentally broken node restart mechanism
as nodes restart things just keep breaking, thus ultimately timeouting the build

I propose we change the --slave-max-restarts default to some sensible number to avoid this issue.

@RonnyPfannschmidt
Copy link
Member

i agree

@RonnyPfannschmidt
Copy link
Member

i propose a default of 4 times the node number

@nicoddemus nicoddemus mentioned this issue Aug 18, 2017
Closed
@nicoddemus
Copy link
Member

Sounds good: #226

@skirpichev skirpichev mentioned this issue Oct 1, 2017
Merged
5 tasks
skirpichev added a commit to skirpichev/diofant that referenced this issue Nov 4, 2017
@skirpichev
Use pytest-xdist on Travis
7eeed60 
We set PYTHONHASHSEED to workaround pytest-dev/pytest-xdist#237.
Unfortunately, number of CPU can't be detected on Travis
(see pytest-dev/pytest-xdist#131), so we also set --numprocesses.

With xdist we can split less: /13 -> /3.
@blueyed
Copy link
Contributor

blueyed commented Jun 1, 2019

Closing as "duplicate" of #226.

@blueyed blueyed closed this as completed Jun 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@nicoulaj @blueyed @thedrow @RonnyPfannschmidt @nicoddemus @liiight