-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change --max-worker-restart option to a sensible value #226
Labels
Comments
I strongly endorse this. We use C++ python modules and sometimes there is a SEGV and it took us a while to understand why we ended up with locked up machines forking processes until the machine begged for mercy. It's highly unlikely that in our case a restart would ever be the right thing to do. |
5 tasks
@timj |
nicoddemus
changed the title
Change --max-slave-restart option to a sensible value
Change --max-worker-restart option to a sensible value
Jun 6, 2019
nicoddemus
added a commit
to nicoddemus/pytest-xdist
that referenced
this issue
Jun 6, 2019
nicoddemus
added a commit
to nicoddemus/pytest-xdist
that referenced
this issue
Jun 6, 2019
nicoddemus
added a commit
to nicoddemus/pytest-xdist
that referenced
this issue
Jun 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The default value allows for infinite restarts, but this is a serious problem for suites which are during collection because the test run never finishes.
We should change the default to a sensible number, @RonnyPfannschmidt suggested 4 times the number of nodes as default. A value of
0
would mean the previous behavior.The text was updated successfully, but these errors were encountered: