Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate looponfail #826

Closed
nicoddemus opened this issue Oct 22, 2022 · 7 comments · Fixed by #827
Closed

Deprecate looponfail #826

nicoddemus opened this issue Oct 22, 2022 · 7 comments · Fixed by #827

Comments

@nicoddemus
Copy link
Member

nicoddemus commented Oct 22, 2022 •
edited
Loading

Follow-up to #543:

Looponfail should eventually be reimplemented in core using subprocess and a hook to register the file system watchers (so pytest plugins could support Realtime Filesystem watching)
nicoddemus added a commit to nicoddemus/pytest-xdist that referenced this issue Oct 22, 2022
@nicoddemus
Deprecate looponfail plugin
86e05fd 
Fix pytest-dev#826
@nicoddemus nicoddemus mentioned this issue Oct 22, 2022
Merged
nicoddemus added a commit to nicoddemus/pytest-xdist that referenced this issue Oct 22, 2022
@nicoddemus
Deprecate looponfail plugin
8b0856a 
Fix pytest-dev#826
@mikelane mikelane mentioned this issue Oct 26, 2022
Merged
bors bot added a commit to microsoft/Qcodes that referenced this issue Oct 26, 2022
@bors @dependabot
Merge #4767
5730890 
4767: Update pytest-xdist requirement from ~=2.5.0 to ~=3.0.2 r=jenshnielsen a=dependabot[bot]

Updates the requirements on [pytest-xdist](https://github.com/pytest-dev/pytest-xdist) to permit the latest version.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/pytest-dev/pytest-xdist/blob/master/CHANGELOG.rst">pytest-xdist's changelog</a>.</em></p>
<blockquote>
<h1>pytest-xdist 3.0.2 (2022-10-25)</h1>
<h2>Bug Fixes</h2>
<ul>
<li><code>[#813](pytest-dev/pytest-xdist#813) &lt;https://github.com/pytest-dev/pytest-xdist/issues/813&gt;</code>_: Cancel shutdown when a crashed worker is restarted.</li>
</ul>
<h2>Deprecations</h2>
<ul>
<li>
<p><code>[#825](pytest-dev/pytest-xdist#825) &lt;https://github.com/pytest-dev/pytest-xdist/issues/825&gt;</code>_: The <code>--rsyncdir</code> command line argument and <code>rsyncdirs</code> config variable are deprecated.</p>
<p>The rsync feature will be removed in pytest-xdist 4.0.</p>
</li>
<li>
<p><code>[#826](pytest-dev/pytest-xdist#826) &lt;https://github.com/pytest-dev/pytest-xdist/issues/826&gt;</code>_: The <code>--looponfail</code> command line argument and <code>looponfailroots</code> config variable are deprecated.</p>
<p>The loop-on-fail feature will be removed in pytest-xdist 4.0.</p>
</li>
</ul>
<h2>Improved Documentation</h2>
<ul>
<li>
<p><code>[#791](pytest-dev/pytest-xdist#791) &lt;https://github.com/pytest-dev/pytest-xdist/issues/791&gt;</code>_: Document the <code>pytest_xdist_auto_num_workers</code> hook.</p>
</li>
<li>
<p><code>[#796](pytest-dev/pytest-xdist#796) &lt;https://github.com/pytest-dev/pytest-xdist/issues/796&gt;</code>_: Added known limitations section to documentation.</p>
</li>
<li>
<p><code>[#829](pytest-dev/pytest-xdist#829) &lt;https://github.com/pytest-dev/pytest-xdist/issues/829&gt;</code>_: Document the <code>-n logical</code> option.</p>
</li>
</ul>
<h2>Features</h2>
<ul>
<li>
<p><code>[#792](pytest-dev/pytest-xdist#792) &lt;https://github.com/pytest-dev/pytest-xdist/issues/792&gt;</code>_: The environment variable <code>PYTEST_XDIST_AUTO_NUM_WORKERS</code> can now be used to
specify the default for <code>-n auto</code> and <code>-n logical</code>.</p>
</li>
<li>
<p><code>[#812](pytest-dev/pytest-xdist#812) &lt;https://github.com/pytest-dev/pytest-xdist/issues/812&gt;</code>_: Partially restore old initial batch distribution algorithm in <code>LoadScheduling</code>.</p>
<p>pytest orders tests for optimal sequential execution - i. e. avoiding
unnecessary setup and teardown of fixtures. So executing tests in consecutive
chunks is important for optimal performance.</p>
<p>In v1.14, initial test distribution in <code>LoadScheduling</code> was changed to
round-robin, optimized for the corner case, when the number of tests is less
than <code>2 * number of nodes</code>. At the same time, it became worse for all other
cases.</p>
<p>For example: if some tests use some &quot;heavy&quot; fixture, and these tests fit into
the initial batch, with round-robin distribution the fixture will be created</p>
</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/pytest-dev/pytest-xdist/commit/eed37d4771f7379156303f63e0d09131f1ac8dee"><code>eed37d4</code></a> Update CHANGELOG</li>
<li><a href="https://github.com/pytest-dev/pytest-xdist/commit/3e9284b6e0b474acaf6f25f8f8db68c78c9cd187"><code>3e9284b</code></a> Merge remote-tracking branch 'upstream/master' into release-3.0.0</li>
<li><a href="https://github.com/pytest-dev/pytest-xdist/commit/ccdab727a29cef7075b853e550eb03aa8de076c1"><code>ccdab72</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/pytest-dev/pytest-xdist/issues/831">#831</a> from pytest-dev/fix-setup</li>
<li><a href="https://github.com/pytest-dev/pytest-xdist/commit/0c981d35475ab6eaee2e6a5ead44442bf07d6e61"><code>0c981d3</code></a> fix and update packaging</li>
<li><a href="https://github.com/pytest-dev/pytest-xdist/commit/38dcf52ae69188b0249eb6307fe6745e2e4174dc"><code>38dcf52</code></a> Release 3.0.1</li>
<li><a href="https://github.com/pytest-dev/pytest-xdist/commit/f2633f1b372dbc58a221cd612c9cb4e79f59eea3"><code>f2633f1</code></a> Fetch all tags, as required by setuptools-scm</li>
<li><a href="https://github.com/pytest-dev/pytest-xdist/commit/192193197bee27228e1e4b44855b3777397e31e5"><code>1921931</code></a> Update CHANGELOG for 3.0</li>
<li><a href="https://github.com/pytest-dev/pytest-xdist/commit/0f58a14def50b9b9112ec25cef97b9593ce86b8a"><code>0f58a14</code></a> Fix towncrier command for latest version</li>
<li><a href="https://github.com/pytest-dev/pytest-xdist/commit/bd23c2460f00129fa0ace7151c8ae18c0a70d5ad"><code>bd23c24</code></a> Fix changelog fragments</li>
<li><a href="https://github.com/pytest-dev/pytest-xdist/commit/794f28bcf4a3711acd074e9637ce8674fb6215be"><code>794f28b</code></a> Use modern syntax for towncrier</li>
<li>Additional commits viewable in <a href="https://github.com/pytest-dev/pytest-xdist/compare/v2.5.0...v3.0.2">compare view</a></li>
</ul>
</details>
<br />


You can trigger a rebase of this PR by commenting ``@dependabot` rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- ``@dependabot` rebase` will rebase this PR
- ``@dependabot` recreate` will recreate this PR, overwriting any edits that have been made to it
- ``@dependabot` merge` will merge this PR after your CI passes on it
- ``@dependabot` squash and merge` will squash and merge this PR after your CI passes on it
- ``@dependabot` cancel merge` will cancel a previously requested merge and block automerging
- ``@dependabot` reopen` will reopen this PR if it is closed
- ``@dependabot` close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- ``@dependabot` ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@avylove
Copy link

avylove commented Oct 28, 2022

It would be useful to provide a link to whatever replaced this functionality, here and in the release notes.

@nicoddemus
Copy link
Member Author

The thing is that there is no real candidate for it at the moment, I'm afraid.

@avylove
Copy link

avylove commented Oct 28, 2022 •
edited
Loading

Then I'd question why it was deprecated. Deprecation requires the user to either stop using this functionality or ignore / suppress the deprecation error. A project I maintain has both filterwarnings = error and looponfailroots in the pytest config. With 3.0.2 this results in the tests failing. So what would you recommend I do here?

Unless there is a security-driven reason for deprecation, I'd request the deprecation be removed until an alternative exists. If there is a security-driven reason, the deprecation warning should be updated with that information.

@nicoddemus
Copy link
Member Author

So what would you recommend I do here?

Do you use that functionality? If not, just remove looponfailroots from the config.

@RonnyPfannschmidt can you elaborate on the reasons why we deprecated loop-on-fail?

@RonnyPfannschmidt
Copy link
Member

its broken in multiple ways (no colors, terminal disconnect, no nested xdist), and at the same is a design constraint for changing xdist itself

so in a sense is a silent coffin nail for xdists future, we just removed the silence, its still a coffin nail

with the deprecatinon in place, we are free to remove the code as soon as a alternative exists instead of a grace period

@avylove avylove mentioned this issue Oct 28, 2022
Merged
bors bot added a commit to microsoft/Qcodes that referenced this issue Dec 5, 2022
@bors @dependabot
Merge #4850 #4852
8480756 
4850: Update google-auth requirement from ~=2.14.0 to ~=2.15.0 r=jenshnielsen a=dependabot[bot]

Updates the requirements on [google-auth](https://github.com/googleapis/google-auth-library-python) to permit the latest version.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/googleapis/google-auth-library-python/releases">google-auth's releases</a>.</em></p>
<blockquote>
<h2>v2.15.0</h2>
<h2><a href="https://github.com/googleapis/google-auth-library-python/compare/v2.14.1...v2.15.0">2.15.0</a> (2022-12-01)</h2>
<h3>Features</h3>
<ul>
<li>Add api_key credentials (<a href="https://github-redirect.dependabot.com/googleapis/google-auth-library-python/issues/1184">#1184</a>) (<a href="https://github.com/googleapis/google-auth-library-python/commit/370293e84a14af0d6c6b34287bdcad020e0580e4">370293e</a>)</li>
<li>Introduce a way to provide scopes granted by user (<a href="https://github-redirect.dependabot.com/googleapis/google-auth-library-python/issues/1189">#1189</a>) (<a href="https://github.com/googleapis/google-auth-library-python/commit/189f504cbdfe043949688dfe55f3f449befad991">189f504</a>)</li>
</ul>
<h3>Bug Fixes</h3>
<ul>
<li>Allow mtls sts endpoint for external account token urls. (<a href="https://github-redirect.dependabot.com/googleapis/google-auth-library-python/issues/1185">#1185</a>) (<a href="https://github.com/googleapis/google-auth-library-python/commit/c86dd69cf79809e2d532a745a236db840fd8bc5d">c86dd69</a>)</li>
<li>CI broken by removal of py.path (<a href="https://github-redirect.dependabot.com/googleapis/google-auth-library-python/issues/1194">#1194</a>) (<a href="https://github.com/googleapis/google-auth-library-python/commit/f719415475e10e5af9ec75b3b13c57c25682bea0">f719415</a>)</li>
<li>Ensure JWT segments have the right types (<a href="https://github-redirect.dependabot.com/googleapis/google-auth-library-python/issues/1162">#1162</a>) (<a href="https://github.com/googleapis/google-auth-library-python/commit/fc843cd318e4ac4f40cf83bbcd7c6eae2b597ff8">fc843cd</a>)</li>
<li>Updated the lower bound of interactive timeout and fix the kwarg… (<a href="https://github-redirect.dependabot.com/googleapis/google-auth-library-python/issues/1182">#1182</a>) (<a href="https://github.com/googleapis/google-auth-library-python/commit/50c0fd29a3b6a4fd6dc4b801d883f5d2b6de88c6">50c0fd2</a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/googleapis/google-auth-library-python/blob/main/CHANGELOG.md">google-auth's changelog</a>.</em></p>
<blockquote>
<h2><a href="https://github.com/googleapis/google-auth-library-python/compare/v2.14.1...v2.15.0">2.15.0</a> (2022-12-01)</h2>
<h3>Features</h3>
<ul>
<li>Add api_key credentials (<a href="https://github-redirect.dependabot.com/googleapis/google-auth-library-python/issues/1184">#1184</a>) (<a href="https://github.com/googleapis/google-auth-library-python/commit/370293e84a14af0d6c6b34287bdcad020e0580e4">370293e</a>)</li>
<li>Introduce a way to provide scopes granted by user (<a href="https://github-redirect.dependabot.com/googleapis/google-auth-library-python/issues/1189">#1189</a>) (<a href="https://github.com/googleapis/google-auth-library-python/commit/189f504cbdfe043949688dfe55f3f449befad991">189f504</a>)</li>
</ul>
<h3>Bug Fixes</h3>
<ul>
<li>Allow mtls sts endpoint for external account token urls. (<a href="https://github-redirect.dependabot.com/googleapis/google-auth-library-python/issues/1185">#1185</a>) (<a href="https://github.com/googleapis/google-auth-library-python/commit/c86dd69cf79809e2d532a745a236db840fd8bc5d">c86dd69</a>)</li>
<li>CI broken by removal of py.path (<a href="https://github-redirect.dependabot.com/googleapis/google-auth-library-python/issues/1194">#1194</a>) (<a href="https://github.com/googleapis/google-auth-library-python/commit/f719415475e10e5af9ec75b3b13c57c25682bea0">f719415</a>)</li>
<li>Ensure JWT segments have the right types (<a href="https://github-redirect.dependabot.com/googleapis/google-auth-library-python/issues/1162">#1162</a>) (<a href="https://github.com/googleapis/google-auth-library-python/commit/fc843cd318e4ac4f40cf83bbcd7c6eae2b597ff8">fc843cd</a>)</li>
<li>Updated the lower bound of interactive timeout and fix the kwarg… (<a href="https://github-redirect.dependabot.com/googleapis/google-auth-library-python/issues/1182">#1182</a>) (<a href="https://github.com/googleapis/google-auth-library-python/commit/50c0fd29a3b6a4fd6dc4b801d883f5d2b6de88c6">50c0fd2</a>)</li>
</ul>
<h2><a href="https://github.com/googleapis/google-auth-library-python/compare/v2.14.0...v2.14.1">2.14.1</a> (2022-11-07)</h2>
<h3>Bug Fixes</h3>
<ul>
<li>Apply quota project for compute cred in adc (<a href="https://github-redirect.dependabot.com/googleapis/google-auth-library-python/issues/1177">#1177</a>) (<a href="https://github.com/googleapis/google-auth-library-python/commit/b9aa92a1f1640f9c8bc4beb7b13051a01cb263a4">b9aa92a</a>)</li>
<li>Update minimum required version of cryptography in pyopenssl extra (<a href="https://github-redirect.dependabot.com/googleapis/google-auth-library-python/issues/1176">#1176</a>) (<a href="https://github.com/googleapis/google-auth-library-python/commit/e9e76d1ee4e4b39edcd6821ced7a5bc3ed60eba0">e9e76d1</a>)</li>
<li>Validate url domain for aws metadata urls (<a href="https://github-redirect.dependabot.com/googleapis/google-auth-library-python/issues/1174">#1174</a>) (<a href="https://github.com/googleapis/google-auth-library-python/commit/f9d7d77739db86870c9b87b003e8ce0c93d53e53">f9d7d77</a>)</li>
</ul>
<h2><a href="https://github.com/googleapis/google-auth-library-python/compare/v2.13.0...v2.14.0">2.14.0</a> (2022-10-31)</h2>
<h3>Features</h3>
<ul>
<li>Add token_info_url to external account credentials (<a href="https://github-redirect.dependabot.com/googleapis/google-auth-library-python/issues/1168">#1168</a>) (<a href="https://github.com/googleapis/google-auth-library-python/commit/9adee75712202234aa0b124a9ca0424654022428">9adee75</a>)</li>
<li>Read Quota Project from Environment Variable (<a href="https://github-redirect.dependabot.com/googleapis/google-auth-library-python/issues/1163">#1163</a>) (<a href="https://github.com/googleapis/google-auth-library-python/commit/57b3e424927a5d86fbab8b231109a5aae1233745">57b3e42</a>)</li>
</ul>
<h3>Bug Fixes</h3>
<ul>
<li>Adding more properties to external_account_authorized_user (<a href="https://github-redirect.dependabot.com/googleapis/google-auth-library-python/issues/1169">#1169</a>) (<a href="https://github.com/googleapis/google-auth-library-python/commit/a12b96dcfa7cb58d9171fd7f2a7ea8331a228419">a12b96d</a>)</li>
</ul>
<h2><a href="https://github.com/googleapis/google-auth-library-python/compare/v2.12.0...v2.13.0">2.13.0</a> (2022-10-14)</h2>
<h3>Features</h3>
<ul>
<li>Adds new external account authorized user credentials (<a href="https://github-redirect.dependabot.com/googleapis/google-auth-library-python/issues/1160">#1160</a>) (<a href="https://github.com/googleapis/google-auth-library-python/commit/523f8117a72548d91f1bb169a3c91b095477ce3b">523f811</a>)</li>
<li>Implement pluggable auth interactive mode (<a href="https://github-redirect.dependabot.com/googleapis/google-auth-library-python/issues/1131">#1131</a>) (<a href="https://github.com/googleapis/google-auth-library-python/commit/44a189fc6185bf33e9d5609cf8d57a846cd98aaf">44a189f</a>)</li>
<li>Introduce the functionality to override token_uri in credentials (<a href="https://github-redirect.dependabot.com/googleapis/google-auth-library-python/issues/1159">#1159</a>) (<a href="https://github.com/googleapis/google-auth-library-python/commit/73bc7e9e0e72b6c5057a13cdb4ac996b754ddb58">73bc7e9</a>)</li>
</ul>
<h3>Bug Fixes</h3>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/googleapis/google-auth-library-python/commit/d85f1ac88be586203266f19cbcbf50faa82f2037"><code>d85f1ac</code></a> chore(main): release 2.15.0 (<a href="https://github-redirect.dependabot.com/googleapis/google-auth-library-python/issues/1183">#1183</a>)</li>
<li><a href="https://github.com/googleapis/google-auth-library-python/commit/189f504cbdfe043949688dfe55f3f449befad991"><code>189f504</code></a> feat: Introduce a way to provide scopes granted by user (<a href="https://github-redirect.dependabot.com/googleapis/google-auth-library-python/issues/1189">#1189</a>)</li>
<li><a href="https://github.com/googleapis/google-auth-library-python/commit/f719415475e10e5af9ec75b3b13c57c25682bea0"><code>f719415</code></a> fix: CI broken by removal of py.path (<a href="https://github-redirect.dependabot.com/googleapis/google-auth-library-python/issues/1194">#1194</a>)</li>
<li><a href="https://github.com/googleapis/google-auth-library-python/commit/c86dd69cf79809e2d532a745a236db840fd8bc5d"><code>c86dd69</code></a> fix: Allow mtls sts endpoint for external account token urls. (<a href="https://github-redirect.dependabot.com/googleapis/google-auth-library-python/issues/1185">#1185</a>)</li>
<li><a href="https://github.com/googleapis/google-auth-library-python/commit/fc843cd318e4ac4f40cf83bbcd7c6eae2b597ff8"><code>fc843cd</code></a> fix: ensure JWT segments have the right types (<a href="https://github-redirect.dependabot.com/googleapis/google-auth-library-python/issues/1162">#1162</a>)</li>
<li><a href="https://github.com/googleapis/google-auth-library-python/commit/370293e84a14af0d6c6b34287bdcad020e0580e4"><code>370293e</code></a> feat: add api_key credentials (<a href="https://github-redirect.dependabot.com/googleapis/google-auth-library-python/issues/1184">#1184</a>)</li>
<li><a href="https://github.com/googleapis/google-auth-library-python/commit/50c0fd29a3b6a4fd6dc4b801d883f5d2b6de88c6"><code>50c0fd2</code></a> fix: updated the lower bound of interactive timeout and fix the kwarg… (<a href="https://github-redirect.dependabot.com/googleapis/google-auth-library-python/issues/1182">#1182</a>)</li>
<li><a href="https://github.com/googleapis/google-auth-library-python/commit/bf95dfc17c15e9e6b71fbfa03c90ab8eb18ade43"><code>bf95dfc</code></a> chore(main): release 2.14.1 (<a href="https://github-redirect.dependabot.com/googleapis/google-auth-library-python/issues/1179">#1179</a>)</li>
<li><a href="https://github.com/googleapis/google-auth-library-python/commit/2d38afd1a7f73134e3a5feb60ef5abcf5bda5cbb"><code>2d38afd</code></a> chore(python): update dependencies in .kokoro/requirements.txt (<a href="https://github-redirect.dependabot.com/googleapis/google-auth-library-python/issues/1180">#1180</a>)</li>
<li><a href="https://github.com/googleapis/google-auth-library-python/commit/f9d7d77739db86870c9b87b003e8ce0c93d53e53"><code>f9d7d77</code></a> fix: Validate url domain for aws metadata urls (<a href="https://github-redirect.dependabot.com/googleapis/google-auth-library-python/issues/1174">#1174</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/googleapis/google-auth-library-python/compare/v2.14.0...v2.15.0">compare view</a></li>
</ul>
</details>
<br />


You can trigger a rebase of this PR by commenting ``@dependabot` rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- ``@dependabot` rebase` will rebase this PR
- ``@dependabot` recreate` will recreate this PR, overwriting any edits that have been made to it
- ``@dependabot` merge` will merge this PR after your CI passes on it
- ``@dependabot` squash and merge` will squash and merge this PR after your CI passes on it
- ``@dependabot` cancel merge` will cancel a previously requested merge and block automerging
- ``@dependabot` reopen` will reopen this PR if it is closed
- ``@dependabot` close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- ``@dependabot` ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>

4852: Update pytest-xdist requirement from ~=3.0.2 to ~=3.1.0 r=jenshnielsen a=dependabot[bot]

Updates the requirements on [pytest-xdist](https://github.com/pytest-dev/pytest-xdist) to permit the latest version.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/pytest-dev/pytest-xdist/blob/master/CHANGELOG.rst">pytest-xdist's changelog</a>.</em></p>
<blockquote>
<h1>pytest-xdist 3.1.0 (2022-12-01)</h1>
<h2>Features</h2>
<ul>
<li>
<p><code>[#789](pytest-dev/pytest-xdist#789) &lt;https://github.com/pytest-dev/pytest-xdist/issues/789&gt;</code>_: Users can now set a default distribution mode in their configuration file:</p>
<p>.. code-block:: ini</p>
<pre><code>[pytest]
addopts = --dist loadscope
</code></pre>
</li>
<li>
<p><code>[#842](pytest-dev/pytest-xdist#842) &lt;https://github.com/pytest-dev/pytest-xdist/issues/842&gt;</code>_: Python 3.11 is now officially supported.</p>
</li>
</ul>
<h2>Removals</h2>
<ul>
<li><code>[#842](pytest-dev/pytest-xdist#842) &lt;https://github.com/pytest-dev/pytest-xdist/issues/842&gt;</code>_: Python 3.6 is no longer supported.</li>
</ul>
<h1>pytest-xdist 3.0.2 (2022-10-25)</h1>
<h2>Bug Fixes</h2>
<ul>
<li><code>[#813](pytest-dev/pytest-xdist#813) &lt;https://github.com/pytest-dev/pytest-xdist/issues/813&gt;</code>_: Cancel shutdown when a crashed worker is restarted.</li>
</ul>
<h2>Deprecations</h2>
<ul>
<li>
<p><code>[#825](pytest-dev/pytest-xdist#825) &lt;https://github.com/pytest-dev/pytest-xdist/issues/825&gt;</code>_: The <code>--rsyncdir</code> command line argument and <code>rsyncdirs</code> config variable are deprecated.</p>
<p>The rsync feature will be removed in pytest-xdist 4.0.</p>
</li>
<li>
<p><code>[#826](pytest-dev/pytest-xdist#826) &lt;https://github.com/pytest-dev/pytest-xdist/issues/826&gt;</code>_: The <code>--looponfail</code> command line argument and <code>looponfailroots</code> config variable are deprecated.</p>
<p>The loop-on-fail feature will be removed in pytest-xdist 4.0.</p>
</li>
</ul>
<h2>Improved Documentation</h2>
<ul>
<li>
<p><code>[#791](pytest-dev/pytest-xdist#791) &lt;https://github.com/pytest-dev/pytest-xdist/issues/791&gt;</code>_: Document the <code>pytest_xdist_auto_num_workers</code> hook.</p>
</li>
<li>
<p><code>[#796](pytest-dev/pytest-xdist#796) &lt;https://github.com/pytest-dev/pytest-xdist/issues/796&gt;</code>_: Added known limitations section to documentation.</p>
</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/pytest-dev/pytest-xdist/commit/92a76bb0139c0c95f89470bfbbd98289321b5543"><code>92a76bb</code></a> Release 3.1.0</li>
<li><a href="https://github.com/pytest-dev/pytest-xdist/commit/6226965dac4df7f7a3b034bc02deb8150d09e2b3"><code>6226965</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/pytest-dev/pytest-xdist/issues/851">#851</a> from nicoddemus/789-default-dist-mode</li>
<li><a href="https://github.com/pytest-dev/pytest-xdist/commit/7a0bc4c1c9a2d8da2f04ad02fc83b2417493863c"><code>7a0bc4c</code></a> Let users configure dist mode in the configuration file</li>
<li><a href="https://github.com/pytest-dev/pytest-xdist/commit/c6bcd204eabeacc75de6ff75339bb731d55ae0cc"><code>c6bcd20</code></a> [pre-commit.ci] pre-commit autoupdate (<a href="https://github-redirect.dependabot.com/pytest-dev/pytest-xdist/issues/849">#849</a>)</li>
<li><a href="https://github.com/pytest-dev/pytest-xdist/commit/99c80c37a44b83f045a577b8ba55c912969a1916"><code>99c80c3</code></a> Fix typo <code>psutils</code> -&gt; <code>psutil</code> (<a href="https://github-redirect.dependabot.com/pytest-dev/pytest-xdist/issues/848">#848</a>)</li>
<li><a href="https://github.com/pytest-dev/pytest-xdist/commit/e14895a96ed7a5c353c6d246c62f6efd47009188"><code>e14895a</code></a> [pre-commit.ci] pre-commit autoupdate (<a href="https://github-redirect.dependabot.com/pytest-dev/pytest-xdist/issues/846">#846</a>)</li>
<li><a href="https://github.com/pytest-dev/pytest-xdist/commit/bb27210cf981c80cd1af3e97b160c79cd8d2d56d"><code>bb27210</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/pytest-dev/pytest-xdist/issues/844">#844</a> from pytest-dev/pre-commit-ci-update-config</li>
<li><a href="https://github.com/pytest-dev/pytest-xdist/commit/4a33933e308dcf4cd4b8ba8906fc1720e419191a"><code>4a33933</code></a> Use ternary operator to remove mypy error</li>
<li><a href="https://github.com/pytest-dev/pytest-xdist/commit/41620d2f469fae063acedde46cb0ed815021f995"><code>41620d2</code></a> [pre-commit.ci] pre-commit autoupdate</li>
<li><a href="https://github.com/pytest-dev/pytest-xdist/commit/6b6f13385096c0fc862b420560b520b6960f718f"><code>6b6f133</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/pytest-dev/pytest-xdist/issues/842">#842</a> from nicoddemus/drop-py36-add-py311</li>
<li>Additional commits viewable in <a href="https://github.com/pytest-dev/pytest-xdist/compare/v3.0.2...v3.1.0">compare view</a></li>
</ul>
</details>
<br />


You can trigger a rebase of this PR by commenting ``@dependabot` rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- ``@dependabot` rebase` will rebase this PR
- ``@dependabot` recreate` will recreate this PR, overwriting any edits that have been made to it
- ``@dependabot` merge` will merge this PR after your CI passes on it
- ``@dependabot` squash and merge` will squash and merge this PR after your CI passes on it
- ``@dependabot` cancel merge` will cancel a previously requested merge and block automerging
- ``@dependabot` reopen` will reopen this PR if it is closed
- ``@dependabot` close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- ``@dependabot` ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@y2kbugger
Copy link

When you say reimplemented in core, you mean in pytest itself? Is there any plan for this?

https://github.com/search?q=%22--looponfail%22&type=code

For a feature that is often used manually at the command line, a lot of people have hardcoded it as the default.

I actually think it's a great idea to move it to core pytest because it is the only feature of pytest-xdist that I ever use, but it is a very nice feature and would be missed.

@RonnyPfannschmidt
Copy link
Member

There is not yet a concrete plan, contribution would be welcome, but it's one big enough to most likely needs some precursor design discussion

folex referenced this issue in fluencelabs/spell Jun 6, 2023
@renovate
chore(deps): update dependency pytest-xdist to v3 (#116)
6267324 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [pytest-xdist](https://github.com/pytest-dev/pytest-xdist)
([changelog](https://pytest-xdist.readthedocs.io/en/latest/changelog.html))
| `==2.5.0` -> `==3.3.1` |
[![age](https://badges.renovateapi.com/packages/pypi/pytest-xdist/3.3.1/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/pypi/pytest-xdist/3.3.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/pypi/pytest-xdist/3.3.1/compatibility-slim/2.5.0)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/pypi/pytest-xdist/3.3.1/confidence-slim/2.5.0)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>pytest-dev/pytest-xdist</summary>

###
[`v3.3.1`](https://github.com/pytest-dev/pytest-xdist/blob/HEAD/CHANGELOG.rst#pytest-xdist-331-2023-05-19)

[Compare
Source](https://github.com/pytest-dev/pytest-xdist/compare/v3.3.0...v3.3.1)

\===============================

## Bug Fixes

- `#&#8203;907
<https://github.com/pytest-dev/pytest-xdist/issues/907>`\_: Avoid remote
calls during startup as `execnet` by default does not ensure remote
affinity with the
main thread and might accidentally schedule the pytest worker into a
non-main thread, which breaks numerous frameworks,
    for example `asyncio`, `anyio`, `PyQt/PySide`, etc.

A more safe correction will require thread affinity in `execnet`
(`pytest-dev/execnet#&#8203;96
<https://github.com/pytest-dev/execnet/issues/96>`\__).

###
[`v3.3.0`](https://github.com/pytest-dev/pytest-xdist/blob/HEAD/CHANGELOG.rst#pytest-xdist-330-2023-05-12)

[Compare
Source](https://github.com/pytest-dev/pytest-xdist/compare/v3.2.1...v3.3.0)

\===============================

## Features

- `#&#8203;555
<https://github.com/pytest-dev/pytest-xdist/issues/555>`\_: Improved
progress output when collecting nodes to be less verbose.

###
[`v3.2.1`](https://github.com/pytest-dev/pytest-xdist/blob/HEAD/CHANGELOG.rst#pytest-xdist-321-2023-03-12)

[Compare
Source](https://github.com/pytest-dev/pytest-xdist/compare/v3.2.0...v3.2.1)

\===============================

## Bug Fixes

- `#&#8203;884
<https://github.com/pytest-dev/pytest-xdist/issues/884>`\_: Fixed hang
in `worksteal` scheduler.

###
[`v3.2.0`](https://github.com/pytest-dev/pytest-xdist/blob/HEAD/CHANGELOG.rst#pytest-xdist-320-2023-02-07)

[Compare
Source](https://github.com/pytest-dev/pytest-xdist/compare/v3.1.0...v3.2.0)

\===============================

## Improved Documentation

- `#&#8203;863
<https://github.com/pytest-dev/pytest-xdist/issues/863>`\_: Document
limitations for debugging due to standard I/O of workers not being
forwarded. Also, mention remote debugging as a possible workaround.

## Features

- `#&#8203;855
<https://github.com/pytest-dev/pytest-xdist/issues/855>`\_: Users can
now configure `load` scheduling precision using `--maxschedchunk`
command
    line option.

- `#&#8203;858
<https://github.com/pytest-dev/pytest-xdist/issues/858>`*: New
`worksteal` scheduler, based on the idea of `work stealing
<https://en.wikipedia.org/wiki/Work_stealing>`*. It's similar to `load`
scheduler, but it should handle tests with significantly differing
duration better, and, at the same time, it should provide similar or
better reuse of fixtures.

## Trivial Changes

- `#&#8203;870
<https://github.com/pytest-dev/pytest-xdist/issues/870>`\_: Make the
tests pass even when `$PYTEST_XDIST_AUTO_NUM_WORKERS` is set.

###
[`v3.1.0`](https://github.com/pytest-dev/pytest-xdist/blob/HEAD/CHANGELOG.rst#pytest-xdist-310-2022-12-01)

[Compare
Source](https://github.com/pytest-dev/pytest-xdist/compare/v3.0.2...v3.1.0)

\===============================

## Features

- `#&#8203;789
<https://github.com/pytest-dev/pytest-xdist/issues/789>`\_: Users can
now set a default distribution mode in their configuration file:

    .. code-block:: ini

        [pytest]
        addopts = --dist loadscope

- `#&#8203;842
<https://github.com/pytest-dev/pytest-xdist/issues/842>`\_: Python 3.11
is now officially supported.

## Removals

- `#&#8203;842
<https://github.com/pytest-dev/pytest-xdist/issues/842>`\_: Python 3.6
is no longer supported.

###
[`v3.0.2`](https://github.com/pytest-dev/pytest-xdist/blob/HEAD/CHANGELOG.rst#pytest-xdist-302-2022-10-25)

[Compare
Source](https://github.com/pytest-dev/pytest-xdist/compare/v2.5.0...v3.0.2)

\===============================

## Bug Fixes

- `#&#8203;813
<https://github.com/pytest-dev/pytest-xdist/issues/813>`\_: Cancel
shutdown when a crashed worker is restarted.

## Deprecations

- `#&#8203;825
<https://github.com/pytest-dev/pytest-xdist/issues/825>`\_: The
`--rsyncdir` command line argument and `rsyncdirs` config variable are
deprecated.

    The rsync feature will be removed in pytest-xdist 4.0.

- `#&#8203;826
<https://github.com/pytest-dev/pytest-xdist/issues/826>`\_: The
`--looponfail` command line argument and `looponfailroots` config
variable are deprecated.

    The loop-on-fail feature will be removed in pytest-xdist 4.0.

## Improved Documentation

- `#&#8203;791
<https://github.com/pytest-dev/pytest-xdist/issues/791>`\_: Document the
`pytest_xdist_auto_num_workers` hook.

- `#&#8203;796
<https://github.com/pytest-dev/pytest-xdist/issues/796>`\_: Added known
limitations section to documentation.

- `#&#8203;829
<https://github.com/pytest-dev/pytest-xdist/issues/829>`\_: Document the
`-n logical` option.

## Features

- `#&#8203;792
<https://github.com/pytest-dev/pytest-xdist/issues/792>`\_: The
environment variable `PYTEST_XDIST_AUTO_NUM_WORKERS` can now be used to
    specify the default for `-n auto` and `-n logical`.

- `#&#8203;812
<https://github.com/pytest-dev/pytest-xdist/issues/812>`\_: Partially
restore old initial batch distribution algorithm in `LoadScheduling`.

pytest orders tests for optimal sequential execution - i. e. avoiding
unnecessary setup and teardown of fixtures. So executing tests in
consecutive
    chunks is important for optimal performance.

In v1.14, initial test distribution in `LoadScheduling` was changed to
round-robin, optimized for the corner case, when the number of tests is
less
than `2 * number of nodes`. At the same time, it became worse for all
other
    cases.

For example: if some tests use some "heavy" fixture, and these tests fit
into
the initial batch, with round-robin distribution the fixture will be
created
`min(n_tests, n_workers)` times, no matter how many other tests there
are.

With the old algorithm (before v1.14), if there are enough tests not
using
    the fixture, the fixture was created only once.

So restore the old behavior for typical cases where the number of tests
is
much greater than the number of workers (or, strictly speaking, when
there
    are at least 2 tests for every node).

## Removals

- `#&#8203;468
<https://github.com/pytest-dev/pytest-xdist/issues/468>`\_: The
`--boxed` command-line option has been removed. If you still need this
functionality, install `pytest-forked
<https://pypi.org/project/pytest-forked>`\__ separately.

## Trivial Changes

- `#&#8203;468
<https://github.com/pytest-dev/pytest-xdist/issues/468>`\_: The `py`
dependency has been dropped.

- `#&#8203;822
<https://github.com/pytest-dev/pytest-xdist/issues/822>`\_: Replace
internal usage of `py.log` with a custom solution (but with the same
interface).

- `#&#8203;823
<https://github.com/pytest-dev/pytest-xdist/issues/823>`\_: Remove usage
of `py._pydir` as an rsync candidate.

- `#&#8203;824
<https://github.com/pytest-dev/pytest-xdist/issues/824>`\_: Replace
internal usages of `py.path.local` by `pathlib.Path`.

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "every weekend" (UTC), Automerge - At
any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/fluencelabs/spell).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS40MC4wIiwidXBkYXRlZEluVmVyIjoiMzUuOTUuMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@jgonggrijp jgonggrijp mentioned this issue Jul 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deprecate looponfail plugin nicoddemus/pytest-xdist
4 participants
@RonnyPfannschmidt @nicoddemus @y2kbugger @avylove