-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement work-stealing scheduler #862
Conversation
Thanks @amezin! I will review it in the next few days. You have made several contributions already, would you like to help maintain the project and become a contributor? |
What does "becoming a contributor" mean? GitHub already shows the "Contributor" badge... |
Basically write access, being able to review/merge PRs, and making releases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good!
Left a few minor comments which would be nice to get in as well.
Did you test this new mode in a large test suite?
Feel free to use type-annotations as well, as we run mypy on the repository. 👍 |
This will be necessary later for 'steal' command. Luckily, all tests still pass after this change.
https://github.com/ddterm/gnome-shell-extension-ddterm/actions/runs/3843994508/jobs/6546739410 Speed/time seems to be indistinguishable from |
Yes, I'm interested. But can't promise I'll be consistently active. |
Sure, no problem, we have no such expectations. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @amezin!
Will merge this in the next few days to give the chance for others to review too. 👍
Closes #858