Allow to skip unittests if --pdb active

[mbyt]

One solution for #2137

[coveralls]

Coverage decreased (-0.08%) to 92.749% when pulling d1c7250 on mbyt:allow_skipping_unittests_with_pdb_active into 0931fe2 on pytest-dev:master.

[coveralls]

Coverage decreased (-0.08%) to 92.749% when pulling 36b6f17 on mbyt:allow_skipping_unittests_with_pdb_active into 0931fe2 on pytest-dev:master.

[nicoddemus]

Overall this looks pretty good, thanks @mbyt for contributing again! 👍

[nicoddemus]

This looks correct according to the implementation in unittest, thanks!

Could you please move this entire logic to a separate method though? Something like:

...
else:
    if self._handle_skip():
        return
    self._testcase.debug()

This makes the code easier to follow IMHO.

[mbyt]

good idea, that makes it much easier to read. I did that in ad56cd8.

[nicoddemus]

I recommend making an explicit version check here; try/except (specially on a generic exception like TypeError) can catch the exception on some unintended part of the code, making it hard to understand/debug the problem.

In short:

if sys.version_info[0] == 3:
    self._testcase._addSkip(self, self._testcase, skip_why)
else:
    self._testcase._addSkip(self, skip_why)

[mbyt]

@nicoddemus that was intentionally, as the python3 _addSkip has the same signature as the unittest2 _addSkip on python2, see here.

However, it was implicit. I explicitly added a comment and secured the PY2 path in 176c680.

[nicoddemus]

(Resolved the changelog conflict directly on the GH interface, that's neat!)

[coveralls]

Coverage decreased (-0.08%) to 92.749% when pulling 176c680 on mbyt:allow_skipping_unittests_with_pdb_active into da5a3db on pytest-dev:master.

[coveralls]

Coverage decreased (-0.1%) to 92.698% when pulling ad56cd8 on mbyt:allow_skipping_unittests_with_pdb_active into da5a3db on pytest-dev:master.

[nicoddemus]

Thanks @mbyt, now I see that it is support both unittest and unittest2 on Python 2.

A try/except for TypeError still makes me uneasy, but I have no better suggestion so let's go with it. 👍

[nicoddemus]

If somebody would like more time to review this please let me know, otherwise I plan to merge this tomorrow evening.

[coveralls]

Coverage decreased (-0.1%) to 92.698% when pulling 6a097aa on mbyt:allow_skipping_unittests_with_pdb_active into a4fb971 on pytest-dev:master.

[nicoddemus]

Thanks again @mbyt!