Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hostname and timestamp to JUnit XML testsuite tag #5692

Merged
merged 2 commits into from
Aug 5, 2019
Merged

Add hostname and timestamp to JUnit XML testsuite tag #5692

merged 2 commits into from
Aug 5, 2019

Conversation

samueljsb
Copy link
Contributor

  • Target the master branch for bug fixes, documentation updates and trivial changes.
  • Include documentation when adding new features.
  • Include new tests or update existing tests when applicable.

Unless your change is trivial or a small documentation fix (e.g., a typo or reword of a small section) please:

  • Create a new changelog file in the changelog folder, with a name like <ISSUE NUMBER>.<TYPE>.rst. See changelog/README.rst for details.
  • Add yourself to AUTHORS in alphabetical order;

Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Great patch!

The change conforms to xunit2. 👍

Some changes though:

  • os.uname is not available on Windows. I believe platform can provide a suitable alternative.
  • Please target features, as this is a new feature and not a bug-fix.

Also it would be great if we could merge this after #5605, but that depends on us.

Thanks again!

@codecov
Copy link

codecov bot commented Aug 3, 2019

Codecov Report

Merging #5692 into features will increase coverage by 0.28%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##           features    #5692      +/-   ##
============================================
+ Coverage     94.53%   94.82%   +0.28%     
============================================
  Files           117      117              
  Lines         25827    25843      +16     
  Branches       2495     2495              
============================================
+ Hits          24416    24505      +89     
+ Misses         1072     1017      -55     
+ Partials        339      321      -18
Impacted Files Coverage Δ
testing/test_junitxml.py 98.18% <100%> (+0.03%) ⬆️
src/_pytest/junitxml.py 95.85% <100%> (+0.61%) ⬆️
src/_pytest/fixtures.py 97.5% <0%> (+0.27%) ⬆️
testing/test_config.py 99.85% <0%> (+0.29%) ⬆️
testing/test_terminal.py 98.43% <0%> (+0.31%) ⬆️
testing/python/fixtures.py 99.08% <0%> (+0.57%) ⬆️
testing/test_parseopt.py 97.93% <0%> (+0.82%) ⬆️
src/_pytest/config/findpaths.py 95.09% <0%> (+0.98%) ⬆️
testing/acceptance_test.py 98.02% <0%> (+0.98%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29e336b...cf6632a. Read the comment docs.

@samueljsb samueljsb changed the base branch from master to features August 3, 2019 14:55
@samueljsb
Copy link
Contributor Author

@nicoddemus I've made the changes - I had forgotten about os.uname on Windows!

@nicoddemus nicoddemus merged commit f7e925d into pytest-dev:features Aug 5, 2019
nicoddemus added a commit to nicoddemus/pytest that referenced this pull request Dec 10, 2019
Add hostname and timestamp to JUnit XML testsuite tag

Conflicts:
  	testing/test_junitxml.py
nicoddemus added a commit that referenced this pull request Dec 10, 2019
[4.6] Add hostname and timestamp to JUnit XML testsuite tag (#5692)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants