-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hostname and timestamp to JUnit XML testsuite tag #5692
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Great patch!
The change conforms to xunit2
. 👍
Some changes though:
os.uname
is not available on Windows. I believeplatform
can provide a suitable alternative.- Please target
features
, as this is a new feature and not a bug-fix.
Also it would be great if we could merge this after #5605, but that depends on us.
Thanks again!
Codecov Report
@@ Coverage Diff @@
## features #5692 +/- ##
============================================
+ Coverage 94.53% 94.82% +0.28%
============================================
Files 117 117
Lines 25827 25843 +16
Branches 2495 2495
============================================
+ Hits 24416 24505 +89
+ Misses 1072 1017 -55
+ Partials 339 321 -18
Continue to review full report at Codecov.
|
@nicoddemus I've made the changes - I had forgotten about |
Add hostname and timestamp to JUnit XML testsuite tag Conflicts: testing/test_junitxml.py
master
branch for bug fixes, documentation updates and trivial changes.Unless your change is trivial or a small documentation fix (e.g., a typo or reword of a small section) please:
changelog
folder, with a name like<ISSUE NUMBER>.<TYPE>.rst
. See changelog/README.rst for details.AUTHORS
in alphabetical order;