-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression in 1.2.x when installing fasttext - can't compile due to not finding pybind and/or pip #6113
Comments
seems to have been broken at #3835, which prevents the |
However fasttext is probably Doing It Wrong by not declaring Probably you can and should fix this over there by pointing them at https://setuptools.pypa.io/en/latest/userguide/dependency_management.html#build-system-requirement and / or submitting an MR. |
I see that facebookresearch/fastText#1223 has been open for a while so I expect that you'll have to submit an MR if you want this fixed, rather than hoping that they take it on themselves. |
I just noticed facebookresearch/fastText#1270, not clear whether this is blocked on no-one being interested or on the contributor signing the CLA. Anyway poetry is not at fault here, this can be closed. |
Thanks for looking into this - I will investigate a fix and submit a MR, apologies for taking the blame to poetry! |
While waiting the issue to be fixed on fastText side, Poetry can install fastText using the prebuilt wheels available from fasttext-wheel PyPI project. |
@juhoinkinen I tried to add fasttext-wheel but poetry keeps complaining it cannot find any versions matching 0.9.2 for fasttext-wheel |
wait so how did this issue get resolved? Poetry still fails when running |
Yes, but Poetry isn't at fault here, |
Thanks @Secrus ! For anyone interested I think the clearest PR to follow is facebookresearch/fastText#1292. Seems like fasttext is pretty dead. as mentioned on there, for anyone looking for a quick workaround:
or what i did (ugly)
|
- see CPJKU/wechsel#2 - also, need to manually track fasstext and install it with pip rather than poetry. see python-poetry/poetry#6113
Summary: Adds pyproject.toml to comply with PEP-518, which fixes the building of the library by poetry - See python-poetry/poetry#6113 . This is a copy of #1270 , but I have signed the CLA. Pull Request resolved: #1292 Differential Revision: D51601444 Pulled By: alexkosau fbshipit-source-id: 357d702281ca3519c3640483eba04d124d0744b4
Summary: Adds pyproject.toml to comply with PEP-518, which fixes the building of the library by poetry - See python-poetry/poetry#6113 . This is a copy of facebookresearch#1270 , but I have signed the CLA. Pull Request resolved: facebookresearch#1292 Differential Revision: D51601444 Pulled By: alexkosau fbshipit-source-id: 357d702281ca3519c3640483eba04d124d0744b4
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
I am on the latest Poetry version.
I have searched the issues of this repo and believe that this is not a duplicate.
If an exception occurs when executing a command, I executed it again in debug mode (
-vvv
option).OS version and name: Ubuntu 22.04 LTS
Poetry version: 1.2.0b3
Link of a Gist with the contents of your pyproject.toml file: https://gist.github.com/cfculhane/f8f9edee4af3ee99deab0170b814e72d
Link to the lockfile: https://gist.github.com/cfculhane/aa093d4333e33d297a8da075d9d43e83
Issue
I've been enjoying the speed and other improvements to the 1.2.x betas, however one package is not installing, and it installs fine on 1.1.14 - fasttext.
Below is the log when installing in 1.2.0b3 with
poetry install -vvv
And the log when the same is run on 1.1.14:
Tried a few things:
Seems to be something with the temp env created for the build? Not quite sure, and it installs totally fine with pip.
The text was updated successfully, but these errors were encountered: