Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip installer: fix installed script executable #3835

Merged
merged 3 commits into from
Mar 26, 2021

Conversation

abn
Copy link
Member

@abn abn commented Mar 25, 2021

When pip installs into an alternate prefix, it uses the current executable
when writing package scripts during install (eg: black, pytest etc.).

With this change, we:

  1. Use the active environment to trigger pip embedded virtual environment.
  2. Enforcing the use of --pep-517 when installing non-wheel packages.
  3. Handle zip-unsafe bug in pip's vendored pep517 under python3.6.

Relates-to: #2826

@abn abn force-pushed the fix/embedded-pip branch 2 times, most recently from 0bf898c to 7afb79f Compare March 25, 2021 23:07
@abn abn force-pushed the fix/embedded-pip branch from 7afb79f to af6ffc9 Compare March 25, 2021 23:15
Copy link
Contributor

@apollo13 apollo13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and will ship it as part of our CI poetry to provide more testing.

@kasteph kasteph merged commit cdfcd14 into python-poetry:master Mar 26, 2021
@abn abn deleted the fix/embedded-pip branch March 26, 2021 11:38
tony added a commit to tony/poetry that referenced this pull request Jan 22, 2022
Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants