Add rich file metadata to poetry.lock

[adisbladis]

This is so files can be distinguished based on their meta attributes.
My proposed solution to #1172.

metadata.hashes is still around though I'd like to start seeing that as deprecated and only for backwards compatibility.

• Added tests for changed code.
• Updated documentation for changed code.

[adisbladis]

Here is a demo of how this metadata can be used: https://github.com/adisbladis/poetry2nix/tree/patched-poetry

[adisbladis]

@sdispater Could I get a comment on if this is something that you'd like to incorporate? Then I can fix the conflicts.

[Caligatio]

Not a maintainer but I think your approach is entirely reasonable. Quickly glanced at your diff and noticed (maybe) some bugs.

[adisbladis]

Not a maintainer but I think your approach is entirely reasonable. Quickly glanced at your diff and noticed (maybe) some bugs.

What bugs did you notice?

[Caligatio]

There is a slight logic bug (I think) with your new files property for a package. In poetry/installation/pip_installer.py, you assume there is a hash key if there is a files property. However, there is an edge case in poetry/repositories/legacy_repository.py in which a hash is not written into the file dict. I believe this would cause a KeyError to be raised on install.

[adisbladis]

@sdispater Is this something that could possibly be merged before 1.0? Since I'm making changes to the lock format itself this needs to go in before 1.0.

[sdispater]

While I agree with the general idea, I think this information should still reside in the metadata section of the lock file as a files property instead of hashes.

[adisbladis]

Since #1460 this can be closed.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.