Improve files metadata in lock files #1460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: adisbladis <adisbladis@gmail.com>
sdispater
force-pushed
the
improve-files-metadata-in-lock-file
branch
from
dd8992c to
2c78625
Compare
2 tasks
michielboekhoff
pushed a commit
to michielboekhoff/poetry
that referenced
this pull request
Oct 29, 2019
Co-authored-by: adisbladis <adisbladis@gmail.com>
michielboekhoff
pushed a commit
to michielboekhoff/poetry
that referenced
this pull request
Oct 29, 2019
Co-authored-by: adisbladis <adisbladis@gmail.com>
3 tasks
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
This PR is an improvement over #1183.
It removes the
hashesmetadata in favor of afilesmetadata which contains the list of files and their hashes for each package.I removed the
package_typeproperty from the original PR since it can be guessed from thefileproperty.It's important to note that it's backwards compatible with the existing lock files.