Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contributing.rst: add instructions for creating virtualenv, update instructions for running w/ coverage #3036

Merged
merged 4 commits into from
Aug 26, 2024

Conversation

jakkdl
Copy link
Member

@jakkdl jakkdl commented Jul 17, 2024

prompted by discussion in #2957, and noticed that docs for running with coverage were outdated.

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.63%. Comparing base (6f614ec) to head (fa4cd94).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3036   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files         121      121           
  Lines       17850    17850           
  Branches     3208     3208           
=======================================
  Hits        17784    17784           
  Misses         46       46           
  Partials       20       20           

docs/source/contributing.rst Outdated Show resolved Hide resolved
docs/source/contributing.rst Show resolved Hide resolved
Copy link
Member

@CoolCat467 CoolCat467 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@A5rocks A5rocks merged commit 7c08af7 into python-trio:main Aug 26, 2024
36 checks passed
@jakkdl jakkdl deleted the venv_instructions branch August 27, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants