-
-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The compatibility problems start with expat 2.4.4, not just 2.4.5 #93018
Comments
@hartwork Would you like to take look at this issue? |
@corona10 had a quick look now, commented at #93022 (review) . Thanks for bringing this to my attention. 👍 |
closing the issue: #93022 (comment) Thank you @hartwork |
corona10
pushed a commit
that referenced
this issue
Dec 7, 2022
mcepl
added a commit
to openSUSE-Python/cpython
that referenced
this issue
Feb 14, 2023
This is another take on python#93022, fixes python#93018. 1. I believe it is inappropriate to assert on the error message for the external API. Error messages are not part of the provided contract with its users. 2. I don't think we are really care what exact exception is thrown, it is much more important that non-well-formed XML is discovered. 3. Changing tests based on the version of library seems as a code smell to me, but that's personal opinion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This
cpython/Lib/test/test_minidom.py
Line 1152 in f20a6a5
and this
cpython/Lib/test/test_minidom.py
Line 1620 in f20a6a5
is wrong. Change of raised errors happened already in 2.4.4 not only in 2.4.5.
The text was updated successfully, but these errors were encountered: