gh-93018: Fix for the compatibility problems with expat started in 2.4.4, not just 2.4.5 #93022
Conversation
There was a problem hiding this comment.
Hi @mcepl, I'm working on libexpat upstream. From a quick look, my impression is that this PR is not about "vanilla" libexpat from upstream but about some distro backport with security fixes backported from after 2.4.4. If it indeed is about a backport, then the distro with the backport needs these fixes downstream, not CPython upstream. For the libexpat change log of 2.4.4, please see https://github.com/libexpat/libexpat/blob/f4501351122606348065d58f62ac06cb7e68a910/expat/Changes#L129-L151 . We may needed changes in CPython tests for the changes in libexpat 2.4.7 though, will need a closer look, and different version guards. What do you think, am I missing something? Best, Sebastian
|
Hmm, just patches for:
|
There was a problem hiding this comment.
Hmm, just patches for:
@mcepl thanks for sharing. That list includes all of the changes introduced in 2.4.5 and more. As-is the changes in this pull request would break the test suite for vanilla libexpat 2.4.4. Any ideas how to not produce that new problem?
|
Hmm, you are probably right. This is a local change caused by our abundance of patches. Sorry for bothering you. |
This is another take on python#93022, fixes python#93018. 1. I believe it is inappropriate to assert on the error message for the external API. Error messages are not part of the provided contract with its users. 2. I don't think we are really care what exact exception is thrown, it is much more important that non-well-formed XML is discovered. 3. Changing tests based on the version of library seems as a code smell to me, but that's personal opinion.
Adjust compatibility fixed for libexpat.
Fixes #93018.