Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge sqlite3.Row (reference) example with the Row How-to Guide #96121

Closed
erlend-aasland opened this issue Aug 19, 2022 · 3 comments · Fixed by #96122
Closed

Merge sqlite3.Row (reference) example with the Row How-to Guide #96121

erlend-aasland opened this issue Aug 19, 2022 · 3 comments · Fixed by #96122
Assignees
@erlend-aasland
Labels
docs Documentation in the Doc dir topic-sqlite3

Comments

@erlend-aasland
Copy link
Contributor

In the sqlite3 docs, there are two examples on how to use the sqlite3.Row row factory:

  1. the sqlite3.Row class reference
  2. the "Accessing columns by name instead of by index"1 how-to guide

Suggesting to improve matters by merging 1. into 2.
That will clean up the reference, and make the how-to more complete.

Footnotes

  1. Yes, it is somewhat clumsy named; we should consider improving that also. ↩
@erlend-aasland erlend-aasland added the docs Documentation in the Doc dir label Aug 19, 2022
@erlend-aasland erlend-aasland self-assigned this Aug 19, 2022
@erlend-aasland
Copy link
Contributor Author

OTOH, the resulting example is very short. It may be better to merge the examples into the reference example and ditch the how-to.

@bedevere-bot bedevere-bot mentioned this issue Aug 19, 2022
Merged
@erlend-aasland erlend-aasland linked a pull request Aug 19, 2022 that will close this issue
gh-96121: Merge sqlite3.Row examples #96122
Merged
@erlend-aasland
Copy link
Contributor Author

Related: a future improvement may be to create a "how to use row factories" how to.

@bedevere-bot bedevere-bot mentioned this issue Aug 22, 2022
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Aug 22, 2022
@miss-islington
pythongh-96121: Merge sqlite3.Row examples into sqlite3.Row class doc (…
dcdcc8b 
…pythonGH-96122)

Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
(cherry picked from commit 18b1782)

Co-authored-by: Erlend E. Aasland <erlend.aasland@innova.no>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Aug 22, 2022
@miss-islington
pythongh-96121: Merge sqlite3.Row examples into sqlite3.Row class doc (…
1bbf082 
…pythonGH-96122)

Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
(cherry picked from commit 18b1782)

Co-authored-by: Erlend E. Aasland <erlend.aasland@innova.no>
@bedevere-bot bedevere-bot mentioned this issue Aug 22, 2022
Merged
erlend-aasland pushed a commit that referenced this issue Aug 22, 2022
@ezio-melotti @CAM-Gerlach
gh-96121: Merge sqlite3.Row examples into sqlite3.Row class doc (#96122)
18b1782 
Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
@erlend-aasland
Copy link
Contributor Author

Resolved with:

miss-islington added a commit that referenced this issue Aug 22, 2022
@miss-islington
gh-96121: Merge sqlite3.Row examples into sqlite3.Row class doc (GH-9…
a836204 
…6122)

Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
(cherry picked from commit 18b1782)

Co-authored-by: Erlend E. Aasland <erlend.aasland@innova.no>
miss-islington added a commit that referenced this issue Aug 22, 2022
@miss-islington
gh-96121: Merge sqlite3.Row examples into sqlite3.Row class doc (GH-9…
98622fa 
…6122)

Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
(cherry picked from commit 18b1782)

Co-authored-by: Erlend E. Aasland <erlend.aasland@innova.no>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erlend-aasland erlend-aasland

Labels
docs Documentation in the Doc dir topic-sqlite3
Projects
sqlite3 issues
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-96121: Merge sqlite3.Row examples erlend-aasland/cpython
1 participant
@erlend-aasland