Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-96121: Merge sqlite3.Row examples #96122

Merged
merged 6 commits into from
Aug 22, 2022
Merged

gh-96121: Merge sqlite3.Row examples #96122

merged 6 commits into from
Aug 22, 2022

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Aug 19, 2022 •
edited by bedevere-bot
Loading

  • Merge sqlite3.Row examples
  • Remove the how-to and incorporate it into the reference

@erlend-aasland erlend-aasland linked an issue Aug 19, 2022 that may be closed by this pull request
Merge sqlite3.Row (reference) example with the Row How-to Guide #96121
Closed
ezio-melotti
ezio-melotti reviewed Aug 19, 2022
View reviewed changes
Doc/library/sqlite3.rst Outdated Show resolved Hide resolved
Doc/library/sqlite3.rst Outdated Show resolved Hide resolved
Doc/library/sqlite3.rst Show resolved Hide resolved
Doc/library/sqlite3.rst Outdated Show resolved Hide resolved
Doc/library/sqlite3.rst Outdated Show resolved Hide resolved
Doc/library/sqlite3.rst Outdated Show resolved Hide resolved
Doc/library/sqlite3.rst Show resolved Hide resolved
@ezio-melotti
Update Doc/library/sqlite3.rst
48dc7d9 
Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
CAM-Gerlach
CAM-Gerlach reviewed Aug 20, 2022
View reviewed changes
Doc/library/sqlite3.rst Outdated Show resolved Hide resolved
Doc/library/sqlite3.rst Outdated Show resolved Hide resolved
Doc/library/sqlite3.rst Outdated Show resolved Hide resolved
CAM-Gerlach
CAM-Gerlach approved these changes Aug 20, 2022
View reviewed changes
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like @ezio-melotti already addressed everything important, so just a couple trivial nits (I was slightly confused by the description of keys(), but that seems a bit out of scope here.

Erlend E. Aasland and others added 2 commits August 20, 2022 09:25
@CAM-Gerlach
Update Doc/library/sqlite3.rst
f83999f 
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
@CAM-Gerlach
Update Doc/library/sqlite3.rst
6ea9b18 
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
@CAM-Gerlach
Copy link
Member

GitHub screwed up my review again, though I think I at least know what it was this time—simply replying to another review comment in one tab with the Comments view open with another in the Files view, which is rather silly.

@erlend-aasland
Copy link
Contributor Author

(I was slightly confused by the description of keys(), but that seems a bit out of scope here.

The second sentence, right? Yes, it reads ... a bit awkward.

@CAM-Gerlach
Copy link
Member

The second sentence, right? Yes, it reads ... a bit awkward.

Yup, in particular I didn't understand why it would only be so "Immediately after a query".

@erlend-aasland erlend-aasland mentioned this pull request Aug 22, 2022
Closed
@erlend-aasland erlend-aasland merged commit 18b1782 into python:main Aug 22, 2022
@miss-islington
Copy link
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@erlend-aasland erlend-aasland deleted the sqlite-docs/row-example branch August 22, 2022 08:03
@bedevere-bot
Copy link

GH-96166 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Aug 22, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 22, 2022
@miss-islington
pythongh-96121: Merge sqlite3.Row examples into sqlite3.Row class doc (…
dcdcc8b 
…pythonGH-96122)

Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
(cherry picked from commit 18b1782)

Co-authored-by: Erlend E. Aasland <erlend.aasland@innova.no>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 22, 2022
@miss-islington
pythongh-96121: Merge sqlite3.Row examples into sqlite3.Row class doc (…
1bbf082 
…pythonGH-96122)

Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
(cherry picked from commit 18b1782)

Co-authored-by: Erlend E. Aasland <erlend.aasland@innova.no>
@bedevere-bot
Copy link

GH-96167 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Aug 22, 2022
@erlend-aasland erlend-aasland mentioned this pull request Aug 22, 2022
Closed
miss-islington added a commit that referenced this pull request Aug 22, 2022
@miss-islington
gh-96121: Merge sqlite3.Row examples into sqlite3.Row class doc (GH-9…
a836204 
…6122)

Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
(cherry picked from commit 18b1782)

Co-authored-by: Erlend E. Aasland <erlend.aasland@innova.no>
miss-islington added a commit that referenced this pull request Aug 22, 2022
@miss-islington
gh-96121: Merge sqlite3.Row examples into sqlite3.Row class doc (GH-9…
98622fa 
…6122)

Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
(cherry picked from commit 18b1782)

Co-authored-by: Erlend E. Aasland <erlend.aasland@innova.no>
@erlend-aasland erlend-aasland mentioned this pull request Aug 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezio-melotti ezio-melotti ezio-melotti left review comments

@CAM-Gerlach CAM-Gerlach CAM-Gerlach approved these changes

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Merge sqlite3.Row (reference) example with the Row How-to Guide
5 participants
@erlend-aasland @CAM-Gerlach @miss-islington @bedevere-bot @ezio-melotti