-
-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-96121: Merge sqlite3.Row examples #96122
gh-96121: Merge sqlite3.Row examples #96122
Conversation
erlend-aasland
commented
Aug 19, 2022
•
edited by bedevere-bot
Loading
edited by bedevere-bot
- Merge sqlite3.Row examples
- Remove the how-to and incorporate it into the reference
- Issue: Merge sqlite3.Row (reference) example with the Row How-to Guide #96121
Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like @ezio-melotti already addressed everything important, so just a couple trivial nits (I was slightly confused by the description of keys()
, but that seems a bit out of scope here.
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
GitHub screwed up my review again, though I think I at least know what it was this time—simply replying to another review comment in one tab with the |
The second sentence, right? Yes, it reads ... a bit awkward. |
Yup, in particular I didn't understand why it would only be so "Immediately after a query". |
Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
GH-96166 is a backport of this pull request to the 3.11 branch. |
…pythonGH-96122) Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com> Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM> (cherry picked from commit 18b1782) Co-authored-by: Erlend E. Aasland <erlend.aasland@innova.no>
…pythonGH-96122) Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com> Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM> (cherry picked from commit 18b1782) Co-authored-by: Erlend E. Aasland <erlend.aasland@innova.no>
GH-96167 is a backport of this pull request to the 3.10 branch. |