Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow: invalid sh syntax #98548

Closed
sterliakov opened this issue Oct 22, 2022 · 4 comments
Closed

Workflow: invalid sh syntax #98548

sterliakov opened this issue Oct 22, 2022 · 4 comments
Labels
type-bug An unexpected behavior, bug, or error

Comments

@sterliakov
Copy link
Contributor

sterliakov commented Oct 22, 2022

Bug report

This bug report is low-priority. I'm reporting the problem with github workflow. The part that checks whether ABI is up-to-date uses nonexistent -neq operator, which should be spelled -ne. As a result, this check is never fired.

Workflow file: https://github.com/python/cpython/actions/runs/3303180763/workflow#L85

Failure example: https://github.com/python/cpython/actions/runs/3303180763/jobs/5450809583#step:6:38

Your environment

Not related.

Introduced in this commit.

I'm going to submit a PR solving this issue soon.

UPD: what branch should I submit against? It is present on 3.x branches (3.7-3.11), but not on main.

@sterliakov sterliakov added the type-bug An unexpected behavior, bug, or error label Oct 22, 2022
@arhadthedev
Copy link
Member

what branch should I submit against

main. A triager or a core developer will add some need packport labels so a bot will submit a copy to the corresponding 3.x after this PR is merged.

@sterliakov
Copy link
Contributor Author

@arhadthedev This action job is not present on main branch, how do I submit against it?..

https://github.com/python/cpython/blob/main/.github/workflows/build.yml

It is on all 3.x branches, but not on main.

@sterliakov
Copy link
Contributor Author

sterliakov commented Oct 22, 2022

Ough, sorry, my bad. It is present on 3.10 and 3.11 only, other branches are not affected. It is a bit weird: 3.10 and 3.11 have this mistake; 3.7-3.9 have this check without error message and main does not contain this job at all. Added by PR's: 3.10, 3.11

@sobolevn
Copy link
Member

Thanks for fixing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

No branches or pull requests

3 participants